Repository navigation
Conversation
abs(PHP_INT_MIN) does not fit into an integer, so clean() with 'uint' returned the float 9.2233720368547758E+18 for '-9223372036854775808' (and for any smaller number, which the int cast saturates to PHP_INT_MIN), breaking the documented integer return type. Clamp it to PHP_INT_MAX. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
InputFilter::clean($value, 'uint')returnsabs((int) $match). ForPHP_INT_MIN('-9223372036854775808', or any smaller number, which the(int)cast turns intoPHP_INT_MIN)abs()cannot return an integer and returns the float9.2233720368547758E+18, breaking the documentedintreturn. The value is now clamped toPHP_INT_MAX.The review also noted that all numeric filters extract the first number found anywhere in the string (
'abc123'gives123). That is long-standing, documented and covered by tests, so it is unchanged; strict validation would be a separate opt-in API.Testing Instructions
New generic case
uint_5inInputFilterTest::casesGeneric()((string) PHP_INT_MINmust givePHP_INT_MAX;testCleanByCallingMember()usesassertSame, so a float fails). It fails before the change and passes after it.Documentation Changes Required
docs/overview.md: theuintline in the type list mentions the clamping.🤖 Generated with Claude Code