Repository navigation
Conversation
headius
marked this pull request as draft
October 9, 2026 01:06
headius
force-pushed
the
all_virtual_threads
branch
from
October 9, 2026 01:11
f8ba86f to
69a6490
Compare
Member
Author
|
Surprisingly, making all threads be vthreads did not break a single test. |
headius
force-pushed
the
all_virtual_threads
branch
from
October 9, 2026 02:02
69a6490 to
de85fd4
Compare
Member
Author
|
I have switched the feature off for now and it can be safely merged any time. We will want to do more experimentation, and perhaps add a JRuby-specific enhancement to allow opting-in for specific threads (e.g. |
headius
marked this pull request as ready for review
October 9, 2026 02:04
Ruby threads have been normal native threads up to now. This patch allows opting into using virtual threads for Ruby threads, in a model closer to m:n threading. New property: jruby.thread.vthread=(true/*false)
headius
force-pushed
the
all_virtual_threads
branch
from
October 9, 2026 02:10
de85fd4 to
51a13a0
Compare
Member
Author
|
I had the logic flipped, actually. Most builds fail with all threads virtual because virtual threads do not appear to be setting up the RubyThreadGroup correctly. I've flipped it back on with corrected logic to try to get things green. |
headius
marked this pull request as draft
October 9, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby threads have been normal native threads up to now. This patch allows opting into using virtual threads for Ruby threads, in a model closer to m:n threading.
New property: jruby.thread.vthread=(true/*false)
Draft for testing with jruby.thread.vthread=true; it should probably be false for upcoming releases and users can opt in.