Visitar URL original
add relaxed lookup-raw interface by khibino · Pull Request #167 · kazu-yamamoto/dns · GitHub
Skip to content

add relaxed lookup-raw interface - #167

Merged
kazu-yamamoto merged 2 commits into
kazu-yamamoto:masterfrom
khibino:lookup-raw-with-recv
Jun 24, 2022
Merged

kazu-yamamoto merged 2 commits into
kazu-yamamoto:masterfrom
khibino:lookup-raw-with-recv

Conversation

@khibino

@khibino khibino commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

Add a new lookupRaw variant.
For example, the current time is not to be retrieved in the recv action, but passed from the outside.

@khibino
khibino marked this pull request as ready for review June 22, 2022 08:26
@kazu-yamamoto
kazu-yamamoto self-requested a review June 23, 2022 07:06
@kazu-yamamoto

Copy link
Copy Markdown
Owner

This PR itself looks good. But what about changing the argument order of "resolve"?
If you like, you can rebase your commit onto https://github.com/kazu-yamamoto/dns/tree/resolve.

@khibino
khibino force-pushed the lookup-raw-with-recv branch from dea2182 to e2c3614 Compare June 24, 2022 01:51

@kazu-yamamoto kazu-yamamoto left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto
kazu-yamamoto merged commit 9f76118 into kazu-yamamoto:master Jun 24, 2022
@kazu-yamamoto

Copy link
Copy Markdown
Owner

Merged. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants