Visitar URL original
Introduce `forkManaged` by edsko · Pull Request #74 · kazu-yamamoto/http2 · GitHub
Skip to content

Introduce forkManaged - #74

Merged
kazu-yamamoto merged 2 commits into
kazu-yamamoto:masterfrom
edsko:edsko/fix-sendRequest
Apr 24, 2023
Merged

kazu-yamamoto merged 2 commits into
kazu-yamamoto:masterfrom
edsko:edsko/fix-sendRequest

Conversation

@edsko

@edsko edsko commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator

Fixes #73.

@edsko edsko mentioned this pull request Apr 20, 2023
@edsko

edsko commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator Author

@kazu-yamamoto I was confused for a while by the use of deleteMyId in worker, since I couldn't find the corresponding addMyId. I think I now understand what is going on, and I tried to add a few comments to explain it. If they are wrong, let me know! :)

@edsko

edsko commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator Author

I think the CI failure is actually #72 . Will fix.

This was a remnant of kazu-yamamoto#72 (CI did not run, I guess).
@kazu-yamamoto
kazu-yamamoto self-requested a review April 24, 2023 01:46

@kazu-yamamoto kazu-yamamoto left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent to me!

@kazu-yamamoto
kazu-yamamoto merged commit 3aa161e into kazu-yamamoto:master Apr 24, 2023
@kazu-yamamoto

Copy link
Copy Markdown
Owner

Thank you for your contribution!

@edsko
edsko deleted the edsko/fix-sendRequest branch April 25, 2023 08:55
kazu-yamamoto added a commit that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in sendRequest?

2 participants