Repository navigation
e2e: harness for full desktop coverage; account and device flows - #29848
Open
chrisnojima wants to merge 1 commit into
Open
chrisnojima wants to merge 1 commit into
chrisnojima wants to merge 1 commit into
Conversation
…secret scan, known failures; account and device flows
chrisnojima
marked this pull request as ready for review
October 29, 2026 18:50
chrisnojima
force-pushed
the
nojima/HOTPOT-e2e-gate-4-harness
branch
from
October 29, 2026 18:50
016f677 to
d6a3fc4
Compare
chrisnojima
force-pushed
the
nojima/HOTPOT-e2e-gate-4-harness
branch
from
October 29, 2026 23:13
d6a3fc4 to
016f677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of eight stacked PRs. The release gate (#29845) now covers every screen and every write action in the desktop app. This PR holds the shared harness pieces the coverage flows build on, plus the account and device flows. PRs 5–7 add flows by area; PR 8 fixes the app bugs the gate found.
Summary
fixtures/corpus/): one small file per type the app previews or uploads (png, jpg, gif, heic, mp4, mov, m4a, pdf, txt, zip, an empty file, a large png, a unicode name), regenerated bymake-corpus.mts.helpers/main-process.ts): open/save dialogs,openExternal, notifications, the focused window and the service socket, through the main process's inspector. Every stub is restored by the fixture, including after a worker died.asSecond/restoreToSmoke,withCleanup(restore first, then delete), and a stored-secret check-or-repair that runs around every flow that signs in as the second account. Rotating the second account's password refuses while a change is pending.retries: 0andtrace: 'off'. The secret scan checks every artifact for every password value the run held, and the release has asecretsphase.known-failures.ts): a deterministic app bug gets a strict failing test of the normal user path plus an entry naming its cause. The entry is only a label in the report; the run still fails.testIDs added in the app (paper key, global errors, menubar rows, block modal, file rows, download footer, relogin list, profile card).Decisions for review
Evidence
The full release on the top of this stack (PR 8): see PR 8.
This branch passes
yarn lint:allandyarn test:unit.