Repository navigation
Fix the bugs the desktop release gate found - #29852
Open
chrisnojima wants to merge 10 commits into
Open
chrisnojima wants to merge 10 commits into
chrisnojima wants to merge 10 commits into
Conversation
In hot dev, Vite serves the renderer as hundreds of module requests to localhost. Without the per-host limit, a reload opens them all at once, overflows the dev server's listen queue, and the reset requests fail as refused, leaving the window blank. Vite's HMR runs over a WebSocket, which the limit doesn't cover. Cold dev and production load from the app scheme and the service's HTTP servers bind 127.0.0.1, so the switch matched nothing there.
chrisnojima
marked this pull request as ready for review
October 29, 2026 18:49
…; chat flows send through peers instead of the simulator
…render mode, coverage census and report
…t only on the e2e team, seed or fail instead of skipping
…secret scan, known failures; account and device flows
menubar: reload recent files on every show. crypto: read the decrypt/verify cause code the service sends as a string. box2: pass onMouseEnter to the desktop element. edit-avatar: save the crop the image opens on when it is left untouched, and open a new image on the default crop. teams: read your showcase of a team from the teams list, send the toggle as set, and disable the box until it is known. simplefs: refuse to start a backup of a folder that was never written, and count it as skipped when backing up all files. settings: say when a single backup did not start; put Dismiss where Cancel was on a finished backup row. The gate's tests for each now pass and their known-failure entries are removed.
chrisnojima
force-pushed
the
nojima/HOTPOT-e2e-gate-8-bug-fixes
branch
from
October 29, 2026 18:50
2dfd2bf to
1ea030f
Compare
…eenshots wait for the screen to settle edit-avatar: a picked image opens scaled to cover the crop circle and centered, and can't be zoomed out past it, so every crop is a full square. Sizes come from layout, not the screen, so a modal still scaling in doesn't skew them. unlock-folders: the device list is left aligned and the paper key input is wider. Gate: a step screenshot waits until the window stops changing (up to 1s). The team page link waits for its tab to load, the paste waits for the upload, a download waits out its Saved toast, giphy and the info panel's media wait for their images, and mark unread gets screenshots of the line and the inbox row. The zoomed-avatar test now actually zooms (its click stopped the zoom) and checks it did; the unzoomed one checks the image fills the circle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eighth of eight stacked PRs. This one fixes the app bugs that the desktop release gate (PRs 1–7) found on master. Each fix is proven by its gate test, which failed on the old code and passes now, and its entry in
known-failures.tsis removed. One known failure is left: the chat-scroll paging drift, which needs its own effort.Fixes
Box2droppedonMouseEnter. It now passes it to its element.SimpleFSArchiveStartreturned an empty job with no error for a folder that was never written. It now refuses that folder:Gate screenshots
These are fixes to the report's evidence, not to the app:
Decisions for review
The avatar crop no longer zooms out below the circle. Before, it could go down to 0.3x, which left gaps and produced non-square crops.
The backup "Skipped N folders" count now includes never-written folders. Its note says so. That's what makes "Started N" true.
A failed single-folder backup still offers "See progress". Changing that is a separate UX call.
Evidence
Full release on this tree (
yarn test:e2e:desktop:release):That run's other failures:
The run before it, on the same fixes, had previews and uploads green.
The avatar, unlock-folders and screenshot changes were checked with a targeted run, not a full release: the 12 affected flows passed (team page link, paste, three drops, both mark-unread tests, the info panel attachments tab, giphy, skin tone, both avatar tests), and
yarn visual:render 'window/unlock-folders*'rendered both screens.Unit tests cover the crypto status mapping,
Box2's desktop events, the crop's cover/centre, zoom floor and unlaid-out fallback, and the showcase source. A Go test covers the never-written folder.yarn lint:all,yarn test:unitandgo test ./kbfs/simplefs/are clean.