Repository navigation
Failing tests: multi-file upload temp dir and chat backup delete - #29854
Draft
chrisnojima wants to merge 1 commit into
Draft
chrisnojima wants to merge 1 commit into
chrisnojima wants to merge 1 commit into
Conversation
…ive delete - simplefs: finishing one upload from a shared SimpleFSMakeTempDirForUpload dir deletes the files the other uploads still need (sequential and back-to-back variants); the dir must still be removed once all are done. - chat: deleting a running archive job leaves output written by the unwinding job, and deleting a finished compressed job leaves its .tar.gzip behind; the deleted job must stay out of the registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing tests, no fixes, for Go bugs the desktop e2e release gate found.
Multi-file upload deletes the shared temp dir (go/kbfs/simplefs)
Desktop drag-and-drop puts every dropped file in one temp dir from
SimpleFSMakeTempDirForUpload. When the first upload finishes,waitForCopyremoves its file's parent dir (dirToDelete) — the shared dir — so the other dropped files are gone before or while they upload.TestUploadSharedTempDirMultipleFiles: two files in one temp dir, uploaded one after the other. Fails with "finishing the first upload removed the second file from the shared temp dir".TestUploadSharedTempDirMultipleFilesConcurrent: a file, a 100-file folder and another file started back to back, as a drop does. Fails with "upload to /private/jdoe/folder: file or folder does not exist". It depends on the first upload finishing before the folder copy does, which held in 50/50 runs.Both also require the shared dir to be removed once every upload from it is done, so a fix can't pass by leaking the copied files.
Chat backup Delete leaves output behind (go/chat)
TestArchiveRegistryDeleteRemovesOutputOfUnwindingJob:ChatArchiveRegistry.Deletecancels a running job and startsos.RemoveAllon its output without waiting for the job to stop. The job, still unwinding, recreates its folders and openschat.txtafter the removal. Fails with "cancelled job wrote into .../kbchat-out after Delete removed it". It also requires the deleted job to stay out of the registry. (Pausehas the same no-wait shape; not tested here.)TestArchiveRegistryDeleteRemovesCompressedOutput: a finished job made withCompress: trueleaves<output>.tar.gzip, andDelete(jobID, true)removes only the directory path. Fails with "Delete left the compressed output .../kbchat-out.tar.gzip behind".Evidence
Each test fails 3/3 on master with
-race, and passes under a stand-in fix (not included). gofmt, go vet andgolangci-lint --new-from-rev origin/masterare clean.