Visitar URL original
Support NodeExternalIP by mikebryant · Pull Request #1799 · kubernetes-retired/heapster · GitHub
Skip to content
This repository was archived by the owner on Dec 1, 2018. It is now read-only.

Support NodeExternalIP - #1799

Merged
DirectXMan12 merged 1 commit into
kubernetes-retired:masterfrom
ocadotechnology:wip-external-ip
Sep 7, 2017
Merged

Support NodeExternalIP#1799
DirectXMan12 merged 1 commit into
kubernetes-retired:masterfrom
ocadotechnology:wip-external-ip

Conversation

@mikebryant

@mikebryant mikebryant commented Sep 4, 2017

Copy link
Copy Markdown
Contributor

Support nodes that look like:

  status:
    addresses:
    - address: 10.0.0.1
      type: ExternalIP
    - address: kubernetes-node-1
      type: Hostname

@mikebryant
Support NodeExternalIP
3d34210 
Support nodes that look like:
```
  status:
    addresses:
    - address: 10.0.0.1
      type: ExternalIP
    - address: kubernetes-node-1
      type: Hostname
```
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 4, 2017
@k8s-reviewable

k8s-reviewable commented Sep 4, 2017

Copy link
Copy Markdown

This change is Reviewable

@k8s-ci-robot

k8s-ci-robot commented Sep 4, 2017

Copy link
Copy Markdown
Contributor

Hi @mikebryant. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 4, 2017
@andyxning

andyxning commented Sep 4, 2017

Copy link
Copy Markdown
Contributor

@DirectXMan12 @piosz This lgtm. PTAL.

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2017
DirectXMan12
DirectXMan12 approved these changes Sep 7, 2017
View reviewed changes

@DirectXMan12 DirectXMan12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DirectXMan12
DirectXMan12 merged commit 8574769 into kubernetes-retired:master Sep 7, 2017
@mikebryant
mikebryant deleted the wip-external-ip branch September 18, 2017 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@DirectXMan12 DirectXMan12 DirectXMan12 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikebryant @k8s-reviewable @k8s-ci-robot @andyxning @DirectXMan12