Visitar URL original
[TEST] GHA: docker tests by vszakats · Pull Request #2628 · libssh2/libssh2 · GitHub
Skip to content

[TEST] GHA: docker tests - #2628

Draft
vszakats wants to merge 39 commits into
libssh2:masterfrom
vszakats:gha-docker-2
Draft

vszakats wants to merge 39 commits into
libssh2:masterfrom
vszakats:gha-docker-2

Conversation

@vszakats

@vszakats vszakats commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

Also:

  • Dockerfile: silence progress in apt commands. For shorter logs.

  • to avoid using external Actions (for simple tasks like this).
  • perhaps look into how this'd look with podman.
  • test --push.
  • always run in PRs, but without --push?
    or rather, have it in a test job with no secrets, write right and login.
  • maybe merge Dockerfile instructions.
  • maybe test on Windows. Also to see if the double-copy workaround is still necessary.

@vszakats
vszakats marked this pull request as draft September 15, 2026 00:12
@vszakats vszakats added the tests label Sep 15, 2026
@vszakats

vszakats commented Sep 15, 2026 •

Copy link
Copy Markdown
Member Author

Tried buliding a docker image in GHA with Docker to test if Dockerfile chmod workarounds from 2016 for Windows are still relevant today. Absolute total disaster to get it moving at all. Not much motivation to repeat it in AppVeyor.

@vszakats
vszakats force-pushed the gha-docker-2 branch 3 times, most recently from 81a05c4 to 229379e Compare October 13, 2026 17:52
move out default sshd_config from the image

try to make a job test "compression no" f

dbg1

ah, needs .conf suffix of course

move another setting out from Containerfile

dbg

dbg2

cleanup

swicth to abs_srcdir, docker on ubuntu 24.04 seems to need it

```
Command: docker logs docker: Error response from daemon: create
../../tests/sshd_config-default.conf:
"../../tests/sshd_config-default.conf" includes invalid characters for a
local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you
intended to pass a host directory, use absolute path
```
https://github.com/libssh2/libssh2/actions/runs/38433388174/job/115421097077#step:25:10352

https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Preset-Output-Variables.html

t1

cleanups

more cleanups 1
```
1: Command: docker run --tty libssh2/openssh_server ls -lA /home/libssh2/.ssh
1: Command: docker run --rm --detach --publish 22 --volume /home/runner/work/libssh2/libssh2/tests//home/runner/work/libssh2/libssh2/tests/sshd_config-compression-no.conf:/etc/ssh/sshd_config.d/2-extra.conf:ro libssh2/openssh_server
```
https://github.com/libssh2/libssh2/actions/runs/38450234904/job/115479040145#step:25:420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant