Repository navigation
pem: reject indefinite-length DER in pem_read_asn1_length() - #2702
Open
abdul-khaliq-khalid wants to merge 2 commits into
Open
abdul-khaliq-khalid wants to merge 2 commits into
abdul-khaliq-khalid wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pem_read_asn1_length() in src/pem.c takes a 0x80 length octet as the long form with zero length bytes, so the
1 + lenlen > datalenguard from #2028 passes with lenlen 0 and the next line still reads data[1], one byte past the element, and uses it as the length. On the libgcrypt backend a PEM RSA or DSA private key whose DER body is just30 80reaches it through libssh2_userauth_publickey_fromfile() or frommemory(), and whether the SEQUENCE is accepted depends on whatever byte happens to follow the span (AddressSanitizer reports a one byte heap-buffer-overflow read on an exactly sized buffer). 0x80 is the DER indefinite form, which never appears in a valid key, so reject it before touching the length bytes; I checked #2028 and #2011 first and this is the one long-form case that fix leaves open. The new test in tests/test_simple.c fails on master and passes with this change.