Visitar URL original
feat(gui): re-apply a drifted client from its Update needed pill by andrew05060414 · Pull Request #8748 · lidge-jun/opencodex · GitHub
Skip to content

feat(gui): re-apply a drifted client from its Update needed pill - #8748

Draft
andrew05060414 wants to merge 1 commit into
lidge-jun:devfrom
andrew05060414:feat/reapply-update-needed-pill
Draft

andrew05060414 wants to merge 1 commit into
lidge-jun:devfrom
andrew05060414:feat/reapply-update-needed-pill

Conversation

@andrew05060414

@andrew05060414 andrew05060414 commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

A client card on the Connect page that reads "Update needed" (the client's config file changed after OpenCodex wrote it) could only be fixed by opening that client's Settings and applying again. The "Update needed" pill is now a button on the card: one click re-applies.

  • Native clients (Claude Desktop, Codex, Claude, Grok Build): the pill sends the same request the card's switch sends, and the card shows " was re-applied." on success or the usual refusal text on failure.
  • File clients: the pill opens the same apply confirmation the switch opens, so nothing is written without the preview.
  • Only offered when the switch is already on. With the switch off, "Update needed" means cleanup is pending and applying would undo the user's choice. Aside is excluded because its apply is per profile.
  • Also fixes a stale badge: after a native toggle the overview did not re-read Claude Desktop's own status route, so its badge could stay on "Update needed" after a successful apply.

Before / after (Claude Desktop card, zh locale):

before
after

Verification

  • bun test (GUI, isolated): tests/integrations-surfaces.test.tsx, tests/integrations-overview-rows.test.ts — 72 pass, including a new test that clicks the pill and checks the PUT body, the success notice, and the badge turning current.
  • bun x tsc -b and bun run lint:i18n in gui/: clean. bun run lint and bun run build ran clean on the integration branch carrying the same change.
  • Manually checked on a local instance (status routes stubbed to report a drifted Claude Desktop): click → button disabled while pending → green notice and "Applied" badge.
  • Full suite not run locally; left to CI (test changed).

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (No user docs describe this pill.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (No auth or secret handling touched.)

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • Required local validation passed; commands, results, and any full-suite exception are documented.

  • I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

A client card that read "Update needed" (its config file changed after
OpenCodex wrote it) could only be fixed by opening Settings and applying
again. The pill is now a button: native clients re-run the same switch
request, file clients open the usual apply confirmation. A native re-apply
reports success on the card, and Claude Desktop's own status is now
refreshed afterwards so the badge actually turns green.
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the enhancement New feature or request label Nov 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
  • ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant