Visitar URL original
Various bugfixes by stgraber · Pull Request #3432 · lxc/incus · GitHub
Skip to content

Various bugfixes - #3432

Merged
stgraber merged 4 commits into
lxc:mainfrom
stgraber:main
May 31, 2026
Merged

Various bugfixes#3432
stgraber merged 4 commits into
lxc:mainfrom
stgraber:main

Conversation

@stgraber

@stgraber stgraber commented May 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #3430

@stgraber

stgraber commented May 30, 2026

Copy link
Copy Markdown
Member Author

@masnax @breml that should help with MM and OC too

@stgraber

stgraber commented May 30, 2026

Copy link
Copy Markdown
Member Author

@gibmat I think all 3 projects use the same logic, so hopefully getting that merged and OC and MM dependencies updated will make things work with Lego v5 and we can re-introduce it to IncusOS (I currently have it reverted to v4).

@github-actions github-actions Bot added the Documentation Documentation needs updating label May 30, 2026
@stgraber stgraber changed the title shared/tls: Add support for Lego v5 Various bugfixes May 30, 2026
stgraber added 4 commits May 31, 2026 08:37
@stgraber
doc/authorization: Fix markdownlint
f110f2d 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber
shared/tls: Add support for Lego v5
ea9eeba 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber
incusd/instance/lxc: Fix environment quoting
a1276cd 
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber
incusd/storage/zfs: Refuse refresh only when snapshots have no common…
e03ff38 
… base

The logic to delete and re-transfer didn't actually work as the volume
root GUID would still be different.

When the target has snapshots but none share a GUID with the source,
refuse the migration, allowing the user to decide whether to delete the
target and do a full transfer or keep things as they are.

When the target has no snapshots at all, there's simply no common base
to build an incremental stream on, so fall back to full transfer.

Closes lxc#3330

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@stgraber

stgraber commented May 31, 2026

Copy link
Copy Markdown
Member Author

@Foxboron this has the fix for the environment issue, it would probably be a good idea to cherry-pick that on your end.

@stgraber

stgraber commented May 31, 2026

Copy link
Copy Markdown
Member Author

Closes #3430

@maveonair I think the environment fix is also the fix you need in your situation.
My guess is that the container on 7.0 was picking up additional environment variables in its configuration, quite possible environment.PATH which would then run into the environment escaping issue causing the failure.

@Foxboron

Foxboron commented May 31, 2026

Copy link
Copy Markdown
Contributor

@stgraber thanks!

@stgraber

stgraber commented May 31, 2026

Copy link
Copy Markdown
Member Author 
stgraber@castiana:~$ incus launch images:debian/13 d13 -c environment.FOO=bar
Launching d13
stgraber@castiana:~$ incus exec d13 -- cat /proc/1/environ | tr '\0' '\n' | grep FOO
FOO="bar"
stgraber@castiana:~$ incus stop d13
stgraber@castiana:~$ # Updating to fixed Incus
stgraber@castiana:~$ incus start d13
stgraber@castiana:~$ incus exec d13 -- cat /proc/1/environ | tr '\0' '\n' | grep FOO
FOO=bar
stgraber@castiana:~$

@maveonair

maveonair commented May 31, 2026

Copy link
Copy Markdown
Member

Closes #3430

@maveonair I think the environment fix is also the fix you need in your situation. My guess is that the container on 7.0 was picking up additional environment variables in its configuration, quite possible environment.PATH which would then run into the environment escaping issue causing the failure.

Thanks!

@stgraber
stgraber merged commit 56ae003 into lxc:main May 31, 2026
99 of 108 checks passed
@maveonair maveonair mentioned this pull request Jun 2, 2026
Closed
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@presztak presztak presztak approved these changes

Assignees

No one assigned

Labels

Documentation Documentation needs updating

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: OCI containers with storage volumes fail due to permission errors in Incus 7.1

4 participants

@stgraber @Foxboron @maveonair @presztak