Visitar URL original
DOC: clarify ConnectionStyle angleA and angleB by QianyeSu · Pull Request #32416 · matplotlib/matplotlib · GitHub
Skip to content

DOC: clarify ConnectionStyle angleA and angleB - #32416

Open
QianyeSu wants to merge 1 commit into
matplotlib:mainfrom
QianyeSu:docs/clarify-fancyarrow-angle-docs
Open

QianyeSu wants to merge 1 commit into
matplotlib:mainfrom
QianyeSu:docs/clarify-fancyarrow-angle-docs

Conversation

@QianyeSu

@QianyeSu QianyeSu commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Fixes #27181.

Summary

  • Clarify that ConnectionStyle.Angle and Angle3 measure angleA and angleB counterclockwise from the positive x-axis at the start and end points, respectively.
  • Explain the start/end interpretation in the pie-and-donut labels example.

This is a documentation-only change; it does not alter the connection path or arrow rendering.

Tests

  • ./.venv/bin/pytest -q lib/matplotlib/tests/test_arrow_patches.py
  • MPLBACKEND=Agg ./.venv/bin/python galleries/examples/pie_and_polar_charts/pie_and_donut_labels.py
  • git diff --check
  • python -m compileall -q lib/matplotlib/patches.py galleries/examples/pie_and_polar_charts/pie_and_donut_labels.py

AI Disclosure

I used an AI coding assistant to help draft the documentation changes and verify the relevant source locations. I reviewed the changes and ran the tests listed above.

Copilot AI balanced review requested due to automatic review settings October 1, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the Documentation: examples files in galleries/examples label Oct 1, 2026
Comment on lines +84 to +87
#
# The ``angle`` connection style measures ``angleA`` at the connection start
# (the text box) and ``angleB`` at the connection end (the annotated wedge).
# Both angles are measured counterclockwise from the positive x-axis.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not add this here. It's too specific for the example, which primarily addresses pie, not connection styles, and only re-states the docstring. If anything, weave a link into the above description. But I think it still works without.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation: examples files in galleries/examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc]: patches.FancyArrowPatch() and Donut demo: angleA and angleB not clearly defined

4 participants