Visitar URL original
Activate LSP for schema and schema extension files by tobias-tengler · Pull Request #4652 · meta/relay · GitHub
Skip to content

Activate LSP for schema and schema extension files - #4652

Closed
tobias-tengler wants to merge 3 commits into
meta:mainfrom
tobias-tengler:activate-lsp-for-graphql-files
Closed

Activate LSP for schema and schema extension files#4652
tobias-tengler wants to merge 3 commits into
meta:mainfrom
tobias-tengler:activate-lsp-for-graphql-files

Conversation

@tobias-tengler

@tobias-tengler tobias-tengler commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

This is in preparation for adding LSP support for schema and schema extension files.

@captbaritone

captbaritone commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Awesome! I'm curious how/if you were able to verify these changes. This LSP stuff can be hard to test (especially when they require changes to the VSCode extension as well)

@tobias-tengler
tobias-tengler force-pushed the activate-lsp-for-graphql-files branch from 9c8e9f5 to b49312f Compare March 15, 2024 21:24
@tobias-tengler

tobias-tengler commented Mar 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yes, I was able to verify it. I started the extension development host and opened my lsp playground repository, which is configured to point to the locally built relay binary. I then observed the extension displaying the Relay: ready message, when I opened the configured schema or a schema extension file.

captbaritone
captbaritone requested changes Mar 15, 2024
View reviewed changes

@captbaritone captbaritone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one qustion

Comment thread compiler/crates/relay-lsp/src/server/lsp_state.rs Resolved
@tobias-tengler

tobias-tengler commented Mar 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@captbaritone Addressed :)

@facebook-github-bot

facebook-github-bot commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

facebook-github-bot commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

@captbaritone merged this pull request in 964e078.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@captbaritone captbaritone captbaritone requested changes

Assignees

No one assigned

Labels

CLA Signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobias-tengler @captbaritone @facebook-github-bot