Visitar URL original
Add SchemaDocument go to definition LSP support by tobias-tengler · Pull Request #4669 · meta/relay · GitHub
Skip to content

Add SchemaDocument go to definition LSP support - #4669

Closed
tobias-tengler wants to merge 1 commit into
meta:mainfrom
tobias-tengler:lsp-schema-go-to-definition
Closed

tobias-tengler wants to merge 1 commit into
meta:mainfrom
tobias-tengler:lsp-schema-go-to-definition

Conversation

@tobias-tengler

@tobias-tengler tobias-tengler commented Apr 5, 2024 •

Copy link
Copy Markdown
Contributor

Adds go to definition support for types and directives within a .graphql file.

@tobias-tengler
tobias-tengler force-pushed the lsp-schema-go-to-definition branch from 397677d to 558ed98 Compare April 5, 2024 20:44
@tobias-tengler
tobias-tengler marked this pull request as ready for review April 5, 2024 20:48
@tobias-tengler
tobias-tengler force-pushed the lsp-schema-go-to-definition branch 2 times, most recently from a09adc0 to 6c1159b Compare April 10, 2024 17:57
@tobias-tengler
tobias-tengler force-pushed the lsp-schema-go-to-definition branch from 6c1159b to e3fb89d Compare April 15, 2024 20:41
@tobias-tengler
tobias-tengler force-pushed the lsp-schema-go-to-definition branch from e3fb89d to 1e89ab0 Compare May 9, 2024 08:59
@tobias-tengler

tobias-tengler commented May 9, 2024 •

Copy link
Copy Markdown
Contributor Author

@captbaritone Thanks for merging the SchemaDocument support :) This is now also ready to be merged.

EDIT: Remember that you need to run the VS Code extension from source when testing. Otherwise the LSP will not be activated for .graphql files. Or alternatively, release a new version of the extension. I've already implemented support and bumped the version in 964e078.

@tobias-tengler
tobias-tengler force-pushed the lsp-schema-go-to-definition branch from 1e89ab0 to 92d9c4b Compare June 14, 2024 04:30
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@captbaritone merged this pull request in 68c7cca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants