Visitar URL original
fix: null reference exception for boolean component schemas by baywet · Pull Request #2839 · microsoft/OpenAPI.NET · GitHub
Skip to content

fix: null reference exception for boolean component schemas #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vincent Biret (baywet) merged 9 commits into from
Apr 27, 2026
Merged

fix: null reference exception for boolean component schemas #2839

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe0b50a
fix: null reference exception for boolean component schemas
baywet Apr 27, 2026
b6c1fe8
test(schema): validate empty schema serialization across all OpenAPI …
baywet Apr 27, 2026
b9b9b75
test(schema): add deserialization tests for empty and boolean schemas
baywet Apr 27, 2026
7d43b15
test(schema): validate false schema deserializes to not with empty ob…
baywet Apr 27, 2026
15c1305
tests: pass serialization format to disambiguate
baywet Apr 27, 2026
05b44be
fix(schema): support boolean schemas in deserializer for OpenAPI 3.1/3.2
baywet Apr 27, 2026
509f332
docs(schema): document boolean schema serialization and deserialization
baywet Apr 27, 2026
7316e3f
perf(schema): optimize boolean schema deserialization
baywet Apr 27, 2026
a54c0fd
test(schema): rename deserialization test for clarity
baywet Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(schema): add deserialization tests for empty and boolean schemas 
Add theory tests across OpenAPI 3.1 and 3.2 to validate deserialization of:
- Empty schema object ({})
- Boolean schema value (true)

These tests ensure that non-standard but valid schema forms are parsed
without errors and produce valid OpenApiSchema objects.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@baywet
baywet and Copilot committed Apr 27, 2026
commit b9b9b7584a2dba829935c27f24df0b7fe5acd96b
12 changes: 12 additions & 0 deletions test/Microsoft.OpenApi.Readers.Tests/V31Tests/OpenApiSchemaTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,5 +844,17 @@ public void ParseSchemaWithoutUnevaluatedPropertiesDefaultsToTrue()
Assert.Equivalent(expected, actual);
Assert.True(actual.UnevaluatedProperties); // Explicitly verify the default
}

[Theory]
[InlineData("{}")]
[InlineData("true")]
public void DeserializeBasicSchemaWorks(string schemaSource)
{
// Arrange & Act
var schema = OpenApiModelFactory.Parse<OpenApiSchema>(schemaSource, OpenApiSpecVersion.OpenApi3_1, new(), out _);

// Assert - schema should deserialize without error
Assert.NotNull(schema);
}
}
}
12 changes: 12 additions & 0 deletions test/Microsoft.OpenApi.Readers.Tests/V32Tests/OpenApiSchemaTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,18 @@ public void ParseSchemaWithUnevaluatedPropertiesComplexSchema()
// Assert
Assert.Equivalent(expected, actual);
}

[Theory]
[InlineData("{}")]
[InlineData("true")]
public void DeserializeBasicSchemaWorks(string schemaSource)
{
// Arrange & Act
var schema = OpenApiModelFactory.Parse<OpenApiSchema>(schemaSource, OpenApiSpecVersion.OpenApi3_2, new(), out _);

// Assert - schema should deserialize without error
Assert.NotNull(schema);
}
}
}