Visitar URL original
fix(v3): retain full JSON pointer path on OpenAPI 3.0 schema references (#3155) by baywet · Pull Request #3170 · microsoft/OpenAPI.NET · GitHub
Skip to content

fix(v3): retain full JSON pointer path on OpenAPI 3.0 schema references (#3155) - #3170

Merged
Vincent Biret (baywet) merged 3 commits into
support/v2from
fix/sub-pointer-to-v2
Nov 13, 2026
Merged

Vincent Biret (baywet) merged 3 commits into
support/v2from
fix/sub-pointer-to-v2

Conversation

@baywet

Copy link
Copy Markdown
Member

port of #3155

…es (#3155)

* fix(v3): retain full JSON pointer path on OpenAPI 3.0 schema references

* test(v3): add unit test for component property schema reference in OpenAPI 3.0

* test(v3): add regression test for nested component subschema references in OpenAPI 3.0
@baywet
Vincent Biret (baywet) requested a review from a team as a code owner November 13, 2026 15:48
@baywet
Vincent Biret (baywet) enabled auto-merge (squash) November 13, 2026 15:48
@github-code-quality

github-code-quality Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: C#

C# / code-coverage/dotnet

support/v2 d8f20e8 fix/sub-pointer-to-v... c661eac +/-
93% 24% -69%
View coverage of the 10 most impacted files.
File support/v2 d8f20e8 fix/sub-pointer-to-v... c661eac +/-
_/src/Verify/Se.../ScrubEngine.cs 0% 29% +29%
_/src/Verify/Ve...rifier_Inner.cs 0% 35% +35%
_/src/Verify/Na...fierSettings.cs 0% 45% +45%
_/src/Verify/Ve...nnerVerifier.cs 0% 46% +46%
_/src/Verify/At...fierSettings.cs 0% 55% +55%
_/src/Verify/Se...fierSettings.cs 0% 64% +64%
_/src/Verify/Se...tionSettings.cs 0% 65% +65%
_/src/Verify/Fi...eNameCleaner.cs 0% 85% +85%
_/src/Verify/Se...eScrubberSet.cs 0% 85% +85%
_/src/EmptyFile...leExtensions.cs 0% 86% +86%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 13, 2026 18:16 UTC

@baywet
Vincent Biret (baywet) marked this pull request as draft November 13, 2026 17:44
auto-merge was automatically disabled November 13, 2026 17:44

Pull request was converted to draft

Restore parsing locations after named examples, including exception paths, and construct locations only when relative reference resolution requires them.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: dc47aa82-c449-43a1-8a70-c4f3c464ae51
Regenerate description and empty-model benchmark reports after repairing example locations and deferring reference path construction.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: dc47aa82-c449-43a1-8a70-c4f3c464ae51
@baywet
Vincent Biret (baywet) marked this pull request as ready for review November 13, 2026 18:16
@baywet
Vincent Biret (baywet) enabled auto-merge (squash) November 13, 2026 18:16
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@baywet
Vincent Biret (baywet) merged commit 16969bc into support/v2 Nov 13, 2026
16 of 17 checks passed
@baywet
Vincent Biret (baywet) deleted the fix/sub-pointer-to-v2 branch November 13, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants