Visitar URL original
fix: restore orderby fallback for unresolved navigation targets by gavinbarron · Pull Request #954 · microsoft/OpenAPI.NET.OData · GitHub
Skip to content

fix: restore orderby fallback for unresolved navigation targets - #954

Open
Gavin Barron (gavinbarron) wants to merge 1 commit into
mainfrom
gavinbarron-restore-unresolved-target-orderby
Open

Gavin Barron (gavinbarron) wants to merge 1 commit into
mainfrom
gavinbarron-restore-unresolved-target-orderby

Conversation

@gavinbarron

Copy link
Copy Markdown
Contributor

Summary

  • Restore navigation-property $orderby fallback only when the annotation target cannot be resolved, including navigation collections after composable functions.
  • Preserve resolved target-path restrictions, including explicit Sortable=false prohibitions.
  • Add five regression cases covering unresolved function targets, property-level sort restrictions, ordinary navigation collections, and path-level precedence.

Validation

  • 316 focused navigation GET, navigation path-item, and parameter-generator tests passed.
  • Confirmed the new allowed-function regression fails before the fix.
  • Checked nine paths against Graph v1.0 CSDL pinned at 06a4f0cac6c8e5bcb7c9149bcfaa32a6e360a174 using the repository's EDM 9.0.0 dependency: six representative unresolved function-containing targets regain $orderby; the three resolved employeeExperience paths with sorting prohibited continue to omit it.

Fixes #952

Fall back to navigation-property sort metadata only when the annotation target cannot be resolved. Preserve explicit path-level sorting prohibitions.

Fixes #952

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@gavinbarron
Gavin Barron (gavinbarron) requested a review from a team as a code owner November 12, 2026 23:34
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Navigation GET loses $orderby when annotation target resolution fails after function segments

1 participant