Visitar URL original
Add support for Query Hints for MS Fabric in TSql170Parser (#180) by ZEUSXXIV · Pull Request #212 · microsoft/SqlScriptDOM · GitHub
Skip to content

Add support for Query Hints for MS Fabric in TSql170Parser (#180) - #212

Merged
Leila Lali (llali) merged 2 commits into
microsoft:mainfrom
ZEUSXXIV:feature/fabric-query-hints
Sep 30, 2026
Merged

Add support for Query Hints for MS Fabric in TSql170Parser (#180)#212
Leila Lali (llali) merged 2 commits into
microsoft:mainfrom
ZEUSXXIV:feature/fabric-query-hints

Conversation

@ZEUSXXIV

@ZEUSXXIV NAVEEN NAIK (ZEUSXXIV) commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #180.

Adds support for MS Fabric query hints (FOR TIMESTAMP AS OF '<literal>', FORCE SINGLE NODE PLAN, and FORCE DISTRIBUTED PLAN) in TSql170Parser, TSql180Parser, and TSqlFabricDWParser. These hints are mapped to AST enums (ForceSingleNodePlan, ForceDistributedPlan, ForTimestampAsOf) and handled appropriately in the T-SQL parser grammar and script generator visitor. Includes new regression unit test coverage.

Code Changes

@llali

Leila Lali (llali) commented Jul 16, 2026

Copy link
Copy Markdown
Member

M1 — Positive-only test coverage; no negative / version-gating assertions.
FabricQueryHints170.sql only exercises the happy path. The repo's testing guidelines call for negative coverage. Because older versions are null (ignored), the test also doesn't lock in that pre-170 parsers reject this syntax. Recommend adding a negative case to ParserErrorsTests.cs (e.g. FORCE SINGLE PLAN missing NODE, or FOR TIMESTAMP AS OF without a string literal) and/or an nErrors160: 1 assertion to pin version gating.

llali
Leila Lali (llali) requested changes Jul 16, 2026
View reviewed changes

@llali Leila Lali (llali) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add negative tests. everything else look good

@ZEUSXXIV
NAVEEN NAIK (ZEUSXXIV) force-pushed the feature/fabric-query-hints branch from 253b7c8 to b845162 Compare July 20, 2026 19:57
@ZEUSXXIV

NAVEEN NAIK (ZEUSXXIV) commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Leila Lali (@llali) Ah yes! I missed out on adding the negative test cases, I have updated the PR accordingly.

@llali
Leila Lali (llali) merged commit eaf3a6e into microsoft:main Sep 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llali Leila Lali (llali) llali approved these changes
@dzsquared Drew Skwiers-Koballa (dzsquared) Awaiting requested review from dzsquared
@chlafreniere Chris LaFreniere (chlafreniere) Awaiting requested review from chlafreniere
@ssreerama Sai Avishkar Sreerama (ssreerama) Awaiting requested review from ssreerama
@kburtram Karl Burtram (kburtram) Awaiting requested review from kburtram kburtram is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Query Hints for MS Fabric in TSql170Parser

2 participants

@ZEUSXXIV @llali