Visitar URL original
Python: Clarify A2A quickstart working directories by shx815 · Pull Request #10177 · microsoft/agent-framework · GitHub
Skip to content

Python: Clarify A2A quickstart working directories - #10177

Open
shx815 wants to merge 4 commits into
microsoft:mainfrom
shx815:docs/a2a-quickstart-client-directory
Open

shx815 wants to merge 4 commits into
microsoft:mainfrom
shx815:docs/a2a-quickstart-client-directory

Conversation

@shx815

@shx815 shx815 commented Nov 8, 2026 •

Copy link
Copy Markdown

Motivation & Context

The A2A hosting quickstart starts in the server sample directory, but the client command uses a path relative to the repository root. Following the instructions from the server directory makes the client's cd command fail.

Description & Review Guide

  • What are the major changes? Specify that server setup starts at the repository root and that the client runs in a separate terminal opened at the repository root.
  • What is the impact of these changes? Readers can follow both sets of commands from the documented working directories.
  • What do you want reviewers to focus on? Check that the server and client steps each state their starting directory clearly.

Verified that the original client path fails from the server sample directory and that the documented path resolves to agent_with_a2a.py from the repository root. git diff --check passed. Validation was limited to the documented paths.

Related Issue

N/A - trivial change. This corrects the working-directory instructions in the A2A hosting quickstart.

AI Assistance

  • No material AI assistance was used.
  • This is an AI-assisted contribution. I reviewed, understood, and verified all submitted content and accept responsibility for it.

AI assistance details: AI identified the working-directory mismatch, drafted the documentation and PR description, and checked the paths locally.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR links to an agreed issue with no competing open PR, or the Related Issue section documents a trivial-change or repository-automation exception.
  • This is not a breaking change.

Copilot AI balanced review requested due to automatic review settings November 8, 2026 13:16
@shx815
shx815 temporarily deployed to github-app-auth November 8, 2026 13:16 — with GitHub Actions Inactive
@shx815
shx815 temporarily deployed to github-app-auth November 8, 2026 13:16 — with GitHub Actions Inactive
@agent-framework-automation agent-framework-automation Bot added documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs python Usage: [Issues, PRs], Target: Python labels Nov 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for this documentation-only clarification of server and client working directories.

No open issues 🎉

What changed in this PR

This documentation-only change clarifies working directories in the Python A2A hosting quickstart so readers can follow the server and client commands correctly.

Changes:

  • Specify that server setup begins at the repository root.
  • Direct readers to open a separate terminal at the repository root before running a client.
File Description
python/​samples/​04-hosting/​a2a/​README.md Clarifies starting directories for server setup and client execution; commands remain unchanged.

Review effort: Balanced

Comment thread python/samples/04-hosting/a2a/README.md Resolved
@shx815
shx815 deployed to github-app-auth November 12, 2026 16:15 — with GitHub Actions Active
@shx815

shx815 commented Nov 12, 2026

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@shx815
shx815 deployed to github-app-auth November 12, 2026 17:30 — with GitHub Actions Active
@shx815
shx815 deployed to github-app-auth November 12, 2026 17:30 — with GitHub Actions Active
@shx815
shx815 deployed to github-app-auth November 12, 2026 17:30 — with GitHub Actions Active
@shx815
shx815 deployed to github-app-auth November 12, 2026 17:30 — with GitHub Actions Active
@shx815
shx815 deployed to github-app-auth November 13, 2026 10:43 — with GitHub Actions Active

This branch was successfully deployed

1 active deployment
github-app-auth — 6321c087 Deployed Nov 13, 2026 by shx815 via add_label #27793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs python Usage: [Issues, PRs], Target: Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants