Visitar URL original
.NET: Add unit tests for RetrieveConversationMessagesExecutor by peibekwe · Pull Request #2388 · microsoft/agent-framework · GitHub
Skip to content

.NET: Add unit tests for RetrieveConversationMessagesExecutor - #2388

Merged
Peter Ibekwe (peibekwe) merged 1 commit into
mainfrom
peibekwe/declarative-tests
Nov 21, 2025
Merged

.NET: Add unit tests for RetrieveConversationMessagesExecutor#2388
Peter Ibekwe (peibekwe) merged 1 commit into
mainfrom
peibekwe/declarative-tests

Conversation

@peibekwe

@peibekwe Peter Ibekwe (peibekwe) commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

This PR adds unit test around the RetrieveConversationMessagesExecutor executor for declarative workflow. Updated MockAgentProvider as required.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings November 21, 2025 20:47
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the .NET Usage: [Issues, PRs], Target: .Net label Nov 21, 2025
@github-actions github-actions Bot changed the title Add unit tests for RetrieveConversationMessagesExecutor .NET: Add unit tests for RetrieveConversationMessagesExecutor Nov 21, 2025
Copilot AI reviewed Nov 21, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive unit tests for the RetrieveConversationMessagesExecutor class in the declarative workflow framework. The changes refactor the MockAgentProvider to better support testing of methods that retrieve multiple messages.

Key changes:

  • New test file with two test cases covering basic and advanced retrieval scenarios
  • Refactored MockAgentProvider from single message to message list support
  • Updated existing RetrieveConversationMessageExecutorTest to work with the refactored mock

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
RetrieveConversationMessagesExecutorTest.cs New test class with tests for retrieving conversation messages with and without optional parameters
MockAgentProvider.cs Refactored to use TestMessages list instead of single TestChatMessage, added GetMessagesAsync mock setup and ToAsyncEnumerableAsync helper
RetrieveConversationMessageExecutorTest.cs Updated to retrieve first message from TestMessages list instead of TestChatMessage property

Comment thread dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/MockAgentProvider.cs Resolved
Comment thread ...s.AI.Workflows.Declarative.UnitTests/ObjectModel/RetrieveConversationMessagesExecutorTest.cs Resolved
@peibekwe
Peter Ibekwe (peibekwe) added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit b7a19b0 Nov 21, 2025
21 checks passed
@crickman
Chris (crickman) deleted the peibekwe/declarative-tests branch November 24, 2025 17:09
This was referenced Dec 5, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 15, 2025
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Dec 22, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Jan 1, 2026
Merged
This was referenced Jan 12, 2026
Closed
Closed
This was referenced Jan 19, 2026
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Feb 2, 2026
Closed
Aris Nguyen (arisng) pushed a commit to arisng/agent-framework that referenced this pull request Feb 2, 2026
@peibekwe
Added unit test for RetrieveConversationMessagesExecutor (microsoft#2388
031aafe 
)
This was referenced Feb 2, 2026
Open
Closed
@dependabot dependabot Bot mentioned this pull request Feb 16, 2026
Closed
This was referenced Feb 23, 2026
Closed
Open
This was referenced Mar 2, 2026
Closed
Open
Open
@dependabot dependabot Bot mentioned this pull request Mar 16, 2026
Merged
@dependabot dependabot Bot mentioned this pull request May 2, 2026
Closed

This branch was previously deployed

1 inactive deployment
integration — b9a0fb74 Deployed Nov 21, 2025 by peibekwe via dotnet-build-and-test (net472, windows-latest, Release, true, integration) #7175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@alliscode Ben Thomas (alliscode) alliscode approved these changes
@lokitoth Jacob Alber (lokitoth) Awaiting requested review from lokitoth
@TaoChenOSU Tao Chen (TaoChenOSU) Awaiting requested review from TaoChenOSU
@moonbox3 Evan Mattson (moonbox3) Awaiting requested review from moonbox3
+1 more reviewer
@crickman Chris (crickman) crickman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@peibekwe Peter Ibekwe (peibekwe)

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

Agent Framework
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peibekwe @alliscode @crickman @markwallace-microsoft