Visitar URL original
.NET: Temporarily suppress CS8002 error by dmytrostruk · Pull Request #2462 · microsoft/agent-framework · GitHub
Skip to content

.NET: Temporarily suppress CS8002 error - #2462

Merged
Dmytro Struk (dmytrostruk) merged 1 commit into
microsoft:mainfrom
dmytrostruk:suppress-anthropic-build-error
Nov 26, 2025
Merged

.NET: Temporarily suppress CS8002 error#2462
Dmytro Struk (dmytrostruk) merged 1 commit into
microsoft:mainfrom
dmytrostruk:suppress-anthropic-build-error

Conversation

@dmytrostruk

@dmytrostruk Dmytro Struk (dmytrostruk) commented Nov 25, 2025

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings November 25, 2025 19:54
@dmytrostruk Dmytro Struk (dmytrostruk) added the .NET Usage: [Issues, PRs], Target: .Net label Nov 25, 2025
Copilot AI reviewed Nov 25, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR centralizes the suppression of the CS8002 compiler warning by moving it from a project-specific configuration to a global setting that applies to all .NET projects in the repository.

  • Moved CS8002 warning suppression from Microsoft.Agents.AI.Anthropic project file to the global Directory.Build.props
  • This applies the suppression repository-wide rather than just to the Anthropic project

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
dotnet/Directory.Build.props Added CS8002 to the global NoWarn list, making the warning suppression apply to all .NET projects in the repository
dotnet/src/Microsoft.Agents.AI.Anthropic/Microsoft.Agents.AI.Anthropic.csproj Removed project-specific CS8002 suppression as it's now handled globally

@dmytrostruk
Dmytro Struk (dmytrostruk) added this pull request to the merge queue Nov 25, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 25, 2025
@dmytrostruk
Dmytro Struk (dmytrostruk) added this pull request to the merge queue Nov 26, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@dmytrostruk
Dmytro Struk (dmytrostruk) added this pull request to the merge queue Nov 26, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Nov 26, 2025
@dmytrostruk
Temporarily suppress CS8002 error (#2462)
083e695
@dmytrostruk
Dmytro Struk (dmytrostruk) removed this pull request from the merge queue due to a manual request Nov 26, 2025
@dmytrostruk
Dmytro Struk (dmytrostruk) merged commit ed53ba1 into microsoft:main Nov 26, 2025
21 checks passed
This was referenced Dec 5, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 8, 2025
Closed
Closed
Closed
Closed
This was referenced Dec 15, 2025
Closed
Merged
Merged
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jan 1, 2026
Merged
This was referenced Jan 12, 2026
Closed
Closed
This was referenced Jan 19, 2026
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Feb 2, 2026
Closed
Aris Nguyen (arisng) pushed a commit to arisng/agent-framework that referenced this pull request Feb 2, 2026
@dmytrostruk
Temporarily suppress CS8002 error (microsoft#2462)
027fe80
This was referenced Feb 2, 2026
Open
Closed
@dependabot dependabot Bot mentioned this pull request Feb 16, 2026
Closed
This was referenced Feb 23, 2026
Closed
Open
This was referenced Mar 2, 2026
Closed
Open
Open
@dependabot dependabot Bot mentioned this pull request Mar 16, 2026
Merged

This branch was previously deployed

1 inactive deployment
integration — d3ccf5a2 Deployed Nov 25, 2025 by dmytrostruk via dotnet-build-and-test (net10.0, ubuntu-latest, Release, true, integration) #7404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes
+1 more reviewer
@TaoChenOSU Tao Chen (TaoChenOSU) TaoChenOSU approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dmytrostruk Dmytro Struk (dmytrostruk)

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmytrostruk @TaoChenOSU @SergeyMenshykh