Visitar URL original
.NET Workflows - Update Declarative Integration Tests for File Cases by crickman · Pull Request #2733 · microsoft/agent-framework · GitHub
Skip to content

.NET Workflows - Update Declarative Integration Tests for File Cases - #2733

Merged
Chris (crickman) merged 5 commits into
mainfrom
crickman/workflow-integration-test-improvements
Dec 9, 2025
Merged

.NET Workflows - Update Declarative Integration Tests for File Cases#2733
Chris (crickman) merged 5 commits into
mainfrom
crickman/workflow-integration-test-improvements

Conversation

@crickman

@crickman Chris (crickman) commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

Refine test-cases around file input for declarative workfows.

Description

  • Improve test validation
  • Separate agent definitions
  • Create appropriate agent for vision tests

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

@crickman Chris (crickman) self-assigned this Dec 9, 2025
@crickman Chris (crickman) added the workflows Usage: [Issues, PRs], Target: Workflows label Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 20:21
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the .NET Usage: [Issues, PRs], Target: .Net label Dec 9, 2025
@crickman Chris (crickman) moved this to In Review in Agent Framework Dec 9, 2025
Copilot AI reviewed Dec 9, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines integration tests for declarative workflows by improving file input handling, separating agent definitions, and creating a dedicated vision agent for testing image and document processing capabilities.

Key Changes

  • Created dedicated VisionAgentProvider for vision-based testing scenarios
  • Refactored tests to support both image and PDF file types with parameterized test cases
  • Enhanced test validation with improved assertions and output logging

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
MediaInput.yaml Simplified workflow configuration by removing inline instructions and referencing dedicated VisionAgent
MediaInputTest.cs Refactored tests from [Fact] to [Theory] to support multiple file types (images and PDFs) with parameterized data
VisionAgentProvider.cs Added new agent provider specifically for vision/document analysis with appropriate instructions
TestAgentProvider.cs Updated agent description to be more generic ("Basic agent") to reflect its general-purpose nature
AgentProvider.cs Extended factory to support creation of VisionAgent through new Names.Vision constant

Comment thread dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs Resolved
Comment thread ...sts/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Agents/VisionAgentProvider.cs Resolved
Comment thread dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs Resolved
Comment thread dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs Resolved
Comment thread dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs Resolved
Comment thread dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs Resolved
Comment thread dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/MediaInputTest.cs Resolved
@crickman
Update dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.Integra…
ec331e7 
…tionTests/Agents/VisionAgentProvider.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@crickman
Chris (crickman) added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 0965a83 Dec 9, 2025
14 checks passed
@crickman
Chris (crickman) deleted the crickman/workflow-integration-test-improvements branch December 9, 2025 22:24
This was referenced Dec 21, 2025
Merged
Merged
Closed
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jan 1, 2026
Merged
This was referenced Jan 12, 2026
Closed
Closed
This was referenced Jan 19, 2026
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Feb 2, 2026
Closed
Aris Nguyen (arisng) pushed a commit to arisng/agent-framework that referenced this pull request Feb 2, 2026
@crickman
.NET Workflows - Update Declarative Integration Tests for File Cases (m…
9144524 
…icrosoft#2733)

* Updated

* Update dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.IntegrationTests/Agents/VisionAgentProvider.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Consistency

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dependabot dependabot Bot mentioned this pull request Feb 2, 2026
Open
This was referenced Feb 9, 2026
Closed
Closed
This was referenced Feb 23, 2026
Closed
Open
This was referenced Mar 2, 2026
Closed
Open
Open
@dependabot dependabot Bot mentioned this pull request Mar 16, 2026
Merged
@dependabot dependabot Bot mentioned this pull request May 2, 2026
Closed
@moonbox3 Evan Mattson (moonbox3) added declarative Usage: [Issues, PRs], Target: declarative agents and workflows and removed declarative-workflow labels Jun 17, 2026

This branch was previously deployed

1 inactive deployment
integration — 53d5b493 Deployed Dec 9, 2025 by crickman via dotnet-build-and-test (net472, windows-latest, Release, true, integration) #8106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@alliscode Ben Thomas (alliscode) alliscode approved these changes
@TaoChenOSU Tao Chen (TaoChenOSU) Awaiting requested review from TaoChenOSU
@lokitoth Jacob Alber (lokitoth) Awaiting requested review from lokitoth
+1 more reviewer
@peibekwe Peter Ibekwe (peibekwe) peibekwe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@crickman Chris (crickman)

Labels

declarative Usage: [Issues, PRs], Target: declarative agents and workflows .NET Usage: [Issues, PRs], Target: .Net workflows Usage: [Issues, PRs], Target: Workflows

Projects

Agent Framework
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@crickman @alliscode @peibekwe @moonbox3 @markwallace-microsoft