Visitar URL original
.NET: Allow overriding the ChatMessageStore to be used per agent run. by westey-m · Pull Request #3330 · microsoft/agent-framework · GitHub
Skip to content

.NET: Allow overriding the ChatMessageStore to be used per agent run. - #3330

Merged
westey (westey-m) merged 4 commits into
microsoft:mainfrom
westey-m:chatmessagestore-allow-perrun-override
Jan 23, 2026
Merged

.NET: Allow overriding the ChatMessageStore to be used per agent run.#3330
westey (westey-m) merged 4 commits into
microsoft:mainfrom
westey-m:chatmessagestore-allow-perrun-override

Conversation

@westey-m

@westey-m westey (westey-m) commented Jan 21, 2026

Copy link
Copy Markdown
Collaborator

Motivation and Context

#3104

Description

  • Allow overriding the ChatMessageStore to be used per agent run via AdditionalProperties
  • Moved all ChatMessageStore and ConversationId tests into a separate test file to reduce the side of the main ChatClientAgentTests file.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings January 21, 2026 14:42
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the .NET Usage: [Issues, PRs], Target: .Net label Jan 21, 2026
@github-actions github-actions Bot changed the title Allow overriding the ChatMessageStore to be used per agent run. .NET: Allow overriding the ChatMessageStore to be used per agent run. Jan 21, 2026
Copilot AI reviewed Jan 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds functionality to allow overriding the ChatMessageStore on a per-agent-run basis via AdditionalProperties. The PR also reorganizes tests by moving ChatMessageStore and ConversationId related tests into a separate file.

Changes:

  • Added AdditionalPropertiesExtensions with type-based key storage/retrieval for AdditionalPropertiesDictionary
  • Implemented ResolveChatMessageStore to support ChatMessageStore overrides via AdditionalProperties
  • Made ChatMessageStoreMessages nullable in InvokedContext to handle first-run scenarios
  • Reorganized tests by moving chat history management tests to a dedicated file

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
dotnet/src/Microsoft.Agents.AI.Abstractions/AdditionalPropertiesExtensions.cs New extension methods for type-based storage/retrieval in AdditionalPropertiesDictionary
dotnet/src/Microsoft.Agents.AI.Abstractions/ChatMessageStore.cs Made ChatMessageStoreMessages parameter nullable in InvokedContext constructor
dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs Added ResolveChatMessageStore method and updated all notification call sites to pass chatOptions
dotnet/tests/Microsoft.Agents.AI.Abstractions.UnitTests/AdditionalPropertiesExtensionsTests.cs Comprehensive tests for AdditionalPropertiesExtensions
dotnet/tests/Microsoft.Agents.AI.UnitTests/ChatClient/ChatClientAgent_ChatHistoryManagementTests.cs New test file consolidating ChatMessageStore and ConversationId tests, including override test
dotnet/tests/Microsoft.Agents.AI.UnitTests/ChatClient/ChatClientAgentTests.cs Removed tests that were moved to ChatHistoryManagementTests
dotnet/tests/Microsoft.Agents.AI.UnitTests/ChatClient/ChatClientAgent_DeserializeThreadTests.cs Namespace changed for consistency
dotnet/tests/Microsoft.Agents.AI.UnitTests/ChatClient/ChatClientAgent_GetNewThreadTests.cs Namespace changed for consistency
dotnet/tests/Microsoft.Agents.AI.UnitTests/ChatClient/ChatClientAgentContinuationTokenTests.cs Namespace changed for consistency

Comment thread ...tests/Microsoft.Agents.AI.UnitTests/ChatClient/ChatClientAgent_ChatHistoryManagementTests.cs Resolved
Comment thread dotnet/tests/Microsoft.Agents.AI.Abstractions.UnitTests/AdditionalPropertiesExtensionsTests.cs Resolved
Comment thread ...tests/Microsoft.Agents.AI.UnitTests/ChatClient/ChatClientAgent_ChatHistoryManagementTests.cs Resolved
Comment thread dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs Resolved
Comment thread dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs Resolved
rogerbarreto
Roger Barreto (rogerbarreto) reviewed Jan 22, 2026
View reviewed changes
Comment thread dotnet/src/Microsoft.Agents.AI.Abstractions/AdditionalPropertiesExtensions.cs Resolved
@westey-m
westey (westey-m) added this pull request to the merge queue Jan 22, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Jan 22, 2026
@westey-m
.NET: Allow overriding the ChatMessageStore to be used per agent run. (…
1b34553 
…#3330)

* Allow overriding the ChatMessageStore to be used per agent run.

* Fix typos

* Fix Add and add TryAdd, Contains and Remove
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 22, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Jan 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Jan 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Jan 23, 2026
This was referenced Mar 9, 2026
Closed
Closed
Open
This was referenced Mar 16, 2026
Closed
Merged
Closed
Open
Closed
Open
Open
Open
Closed
Closed
Closed
This was referenced Apr 6, 2026
Closed
Open
Open
This was referenced May 2, 2026
Closed
Closed
Merged
This was referenced May 9, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced May 18, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jun 10, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jun 24, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jul 15, 2026
Open

This branch was previously deployed

1 inactive deployment
integration — 33ff003a Deployed Jan 22, 2026 by westey-m via dotnet-build-and-test (net10.0, ubuntu-latest, Release, true, integration) #9946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rogerbarreto Roger Barreto (rogerbarreto) rogerbarreto approved these changes
@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

Assignees

No one assigned

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@westey-m @rogerbarreto @SergeyMenshykh @markwallace-microsoft