Visitar URL original
.NET: Improve unit test coverage for Microsoft.Agents.AI.AzureAI.Persistent by Copilot · Pull Request #3384 · microsoft/agent-framework · GitHub
Skip to content

.NET: Improve unit test coverage for Microsoft.Agents.AI.AzureAI.Persistent - #3384

Merged
Roger Barreto (rogerbarreto) merged 4 commits into
mainfrom
copilot/improve-unit-test-coverage-one-more-time
Jan 26, 2026
Merged

.NET: Improve unit test coverage for Microsoft.Agents.AI.AzureAI.Persistent#3384
Roger Barreto (rogerbarreto) merged 4 commits into
mainfrom
copilot/improve-unit-test-coverage-one-more-time

Conversation

Copilot AI commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Analyze current code coverage and identify non-covered paths
  • Run existing tests to ensure they pass (25 tests passing initially)
  • Add tests for AsAIAgent overload with ChatOptions
    • Test null client handling
    • Test null response handling
    • Test null persistentAgent handling
    • Test instructions from agent metadata when chatOptions is null
    • Test instructions from agent metadata when chatOptions.Instructions is null
    • Test instructions NOT overridden when chatOptions has explicit instructions
    • Test clientFactory application with ChatOptions
  • Add tests for ConvertAIToolsToToolDefinitions private method via CreateAIAgentAsync
    • Test HostedCodeInterpreterTool handling
    • Test HostedCodeInterpreterTool with HostedFileContent inputs
    • Test HostedFileSearchTool handling
    • Test HostedFileSearchTool with HostedVectorStoreContent inputs
    • Test HostedWebSearchTool handling with connectionId
    • Test HostedWebSearchTool without connectionId (falls to default)
    • Test default fallback for unknown/function tools
    • Test mixed tools scenario
  • Add tests for GetAIAgentAsync and CreateAIAgentAsync with options
    • Test null options handling
    • Test clientFactory with options
    • Test services with options
  • Verify all tests pass (50 tests total - all passing)
  • Coverage improved from 59.2% to 97.9% line rate and 97.45% branch rate
  • Fix redundant cast error IDE0004
Original prompt

This section details on the original issue you should resolve

<issue_title>.NET: Improve unit test coverage for Microsoft.Agents.AI.AzureAI.Persistent</issue_title>
<issue_description>Required level is 85%

Image</issue_description>

<agent_instructions>Please analyze the Cobertura Coverage information related to the Microsoft.Agents.AI.AzureAI.Persistent and lets improve its coverage on non-covered paths.

Please keep the same patterns used for UnitTests existing into the Microsoft.Agents.AI.AzureAI.Persistent.UnitTests.

Use our repository guidelines regarding UnitTests code as well as use our existing File approach for the UnitTests generation, only creating new ones if the file being covered have not being covered yet.

Ensure the coverage only covers non-covered paths without duplicating paths that are already covered.

Ensure all existing tests are working on top of the new added ones. This change should only be focused in UnitTests not changing any functionality.</agent_instructions>

Comments on the Issue (you are Copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@rogerbarreto
Add unit tests to improve coverage for Microsoft.Agents.AI.AzureAI.Pe…
7c22df1 
…rsistent

Co-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>
Copilot AI changed the title [WIP] Improve unit test coverage for Microsoft.Agents.AI.AzureAI.Persistent Improve unit test coverage for Microsoft.Agents.AI.AzureAI.Persistent Jan 22, 2026
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the .NET Usage: [Issues, PRs], Target: .Net label Jan 23, 2026
@github-actions github-actions Bot changed the title Improve unit test coverage for Microsoft.Agents.AI.AzureAI.Persistent .NET: Improve unit test coverage for Microsoft.Agents.AI.AzureAI.Persistent Jan 23, 2026
@rogerbarreto

Roger Barreto (rogerbarreto) commented Jan 23, 2026

Copy link
Copy Markdown
Member

Copilot

Format issues happening below.

/app/dotnet/tests/Microsoft.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs(584,30): error IDE0004: Cast is redundant. [/app/dotnet/tests/Microsoft.Agents.AI.AzureAI.Persistent.UnitTests/Microsoft.Agents.AI.AzureAI.Persistent.UnitTests.csproj]
/app/dotnet/tests/Microsoft.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs(584,30): error IDE0004: Cast is redundant. [/app/dotnet/tests/Microsoft.Agents.AI.AzureAI.Persistent.UnitTests/Microsoft.Agents.AI.AzureAI.Persistent.UnitTests.csproj]

@rogerbarreto
Fix redundant cast error IDE0004
41240ef 
Co-authored-by: rogerbarreto <19890735+rogerbarreto@users.noreply.github.com>

Copilot AI commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Copilot

Format issues happening below.
...

Fixed in 41240ef by removing the redundant cast and using the named parameter persistentAgentResponse: null! instead.

@rogerbarreto
Roger Barreto (rogerbarreto) marked this pull request as ready for review January 23, 2026 12:55
Copilot AI review requested due to automatic review settings January 23, 2026 12:55
Copilot AI reviewed Jan 23, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR significantly improves unit test coverage for the Microsoft.Agents.AI.AzureAI.Persistent namespace, targeting the PersistentAgentsClientExtensions class. The PR successfully increases coverage from 59.2% to 97.9% line rate and 97.45% branch rate by adding comprehensive tests for previously uncovered code paths.

Changes:

  • Added 25 new test methods covering various overloads of AsAIAgent, GetAIAgentAsync, and CreateAIAgentAsync methods
  • Added comprehensive tests for the ConvertAIToolsToToolDefinitions private method by testing CreateAIAgentAsync with different tool types
  • Added tests for null parameter validation, instructions handling, clientFactory application, and services propagation

Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
Comment thread ...t.Agents.AI.AzureAI.Persistent.UnitTests/Extensions/PersistentAgentsClientExtensionsTests.cs Resolved
@rogerbarreto
Roger Barreto (rogerbarreto) added this pull request to the merge queue Jan 23, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2026
This was referenced Mar 9, 2026
Closed
Closed
Open
This was referenced Mar 16, 2026
Closed
Merged
Closed
Open
Closed
Open
Open
Open
Closed
Closed
Closed
This was referenced Apr 6, 2026
Closed
Open
Open
This was referenced May 2, 2026
Closed
Closed
Merged
This was referenced May 9, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced May 18, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jun 10, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jun 24, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jul 15, 2026
Open

This branch was previously deployed

1 inactive deployment
integration — d40935d7 Deployed Jan 26, 2026 by rogerbarreto via dotnet-build-and-test (net472, windows-latest, Release, true, integration) #10106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes
@westey-m westey (westey-m) westey-m approved these changes
@rogerbarreto Roger Barreto (rogerbarreto) Awaiting requested review from rogerbarreto rogerbarreto is a code owner

Assignees

@rogerbarreto Roger Barreto (rogerbarreto)

Copilot code review Copilot

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.NET: Improve unit test coverage for Microsoft.Agents.AI.AzureAI.Persistent

6 participants

@rogerbarreto @SergeyMenshykh @westey-m @markwallace-microsoft