Visitar URL original
.NET Workflows - Add unit tests for QuestionExecutor by Copilot · Pull Request #3892 · microsoft/agent-framework · GitHub
Skip to content

.NET Workflows - Add unit tests for QuestionExecutor - #3892

Merged
Chris (crickman) merged 10 commits into
mainfrom
copilot/add-unit-test-class-for-questionexecutor
Feb 17, 2026
Merged

.NET Workflows - Add unit tests for QuestionExecutor#3892
Chris (crickman) merged 10 commits into
mainfrom
copilot/add-unit-test-class-for-questionexecutor

Conversation

Copilot AI commented Feb 12, 2026 •
edited by crickman
Loading

Copy link
Copy Markdown
Contributor

Motivation and Context

QuestionExecutor lacked unit test coverage.

Description

Created QuestionExecutorTest with 100% coverage.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI and others added 2 commits February 12, 2026 18:59
@crickman
Add comprehensive unit tests for QuestionExecutor
f9c785b 
Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
@crickman
Address code review feedback and add additional test for default valu…
93ed85b 
…e logic

Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
Copilot AI changed the title [WIP] Add unit test class for QuestionExecutor Add comprehensive unit tests for QuestionExecutor Feb 12, 2026
@crickman Chris (crickman) changed the title Add comprehensive unit tests for QuestionExecutor .NET Workflows - Add unit tests for QuestionExecutor Feb 13, 2026
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the .NET Usage: [Issues, PRs], Target: .Net label Feb 16, 2026
@crickman
Chris (crickman) marked this pull request as ready for review February 16, 2026 23:39
Copilot AI review requested due to automatic review settings February 16, 2026 23:39
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the workflows Usage: [Issues, PRs], Target: Workflows label Feb 16, 2026
@crickman Chris (crickman) moved this to In Review in Agent Framework Feb 16, 2026
Copilot AI reviewed Feb 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds unit test coverage for the declarative workflow QuestionExecutor and adjusts executor behavior to align with the tested scenarios.

Changes:

  • Added a new QuestionExecutorTest suite covering step naming, completion detection, execute/prepare/capture/complete handlers, autosend behavior, and repeat-count scenarios.
  • Updated QuestionExecutor logic for prompting decisions (AlwaysPrompt + SkipQuestionMode + variable state).
  • Updated QuestionExecutor capture/prompt handling to avoid null-prompt crashes and to handle missing default values when repeat count is exceeded.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/QuestionExecutorTest.cs New unit test suite covering QuestionExecutor execution paths and handler behaviors.
dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/QuestionExecutor.cs Behavior updates to prompting decision logic, capture assignment null-safety, and repeat-count/default handling.

Comment thread dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/QuestionExecutor.cs Resolved
Comment thread ...ests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/QuestionExecutorTest.cs Resolved
Comment thread dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/QuestionExecutor.cs Resolved
Comment thread dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/QuestionExecutor.cs Resolved
This was referenced Mar 9, 2026
Closed
Open
Closed
This was referenced Mar 16, 2026
Merged
Closed
Open
Closed
Open
Closed
Closed
Closed
Merged
Closed
This was referenced Apr 6, 2026
Closed
Open
Open
@dependabot dependabot Bot mentioned this pull request Apr 24, 2026
Merged
This was referenced May 2, 2026
Closed
Closed
This was referenced May 9, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced May 18, 2026
Closed
Closed
This was referenced Jun 6, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jun 24, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jul 15, 2026
Open

This branch was previously deployed

1 inactive deployment
integration — 678ee2d2 Deployed Feb 17, 2026 by crickman via dotnet-build-and-test (net10.0, ubuntu-latest, Release, true, integration) #12133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@alliscode Ben Thomas (alliscode) alliscode approved these changes
+2 more reviewers
@crickman Chris (crickman) crickman approved these changes
@peibekwe Peter Ibekwe (peibekwe) peibekwe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@crickman Chris (crickman)

Copilot code review Copilot

Labels

.NET Usage: [Issues, PRs], Target: .Net workflows Usage: [Issues, PRs], Target: Workflows

Projects

Agent Framework
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alliscode @crickman @peibekwe @markwallace-microsoft