Visitar URL original
.NET: Fix sample resource path resolution by westey-m · Pull Request #3952 · microsoft/agent-framework · GitHub
Skip to content

.NET: Fix sample resource path resolution - #3952

Merged
westey (westey-m) merged 1 commit into
microsoft:mainfrom
westey-m:samples-resource-path-fix
Feb 17, 2026
Merged

.NET: Fix sample resource path resolution#3952
westey (westey-m) merged 1 commit into
microsoft:mainfrom
westey-m:samples-resource-path-fix

Conversation

@westey-m

@westey-m westey (westey-m) commented Feb 16, 2026

Copy link
Copy Markdown
Collaborator

Motivation and Context

The samples were working when run from Visual Studio, but failing when using dotnet run due to the difference in the path from which they were executed.

Description

  • Change resource resolution to be relative to the executable's path.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings February 16, 2026 12:40
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added the .NET Usage: [Issues, PRs], Target: .Net label Feb 16, 2026
@github-actions github-actions Bot changed the title Fix sample resource path resolution .NET: Fix sample resource path resolution Feb 16, 2026
Copilot AI reviewed Feb 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates .NET GettingStarted workflow samples to load text resources relative to the executable output directory (instead of the current working directory), fixing failures when running via dotnet run.

Changes:

  • Switch resource file loading from a relative path (Resources/...) to Path.Combine(AppContext.BaseDirectory, "Resources", ...) across affected samples.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
dotnet/samples/GettingStarted/Workflows/SharedStates/Resources.cs Reads resources from the app base directory to work under dotnet run.
dotnet/samples/GettingStarted/Workflows/ConditionalEdges/01_EdgeCondition/Resources.cs Same base-directory resource resolution change for this sample.
dotnet/samples/GettingStarted/Workflows/ConditionalEdges/02_SwitchCase/Resources.cs Same base-directory resource resolution change for this sample.
dotnet/samples/GettingStarted/Workflows/ConditionalEdges/03_MultiSelection/Resources.cs Same base-directory resource resolution change for this sample.

@westey-m
westey (westey-m) added this pull request to the merge queue Feb 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 17, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Feb 17, 2026
@westey-m
westey (westey-m) removed this pull request from the merge queue due to a manual request Feb 17, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Feb 17, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Feb 17, 2026
@westey-m
Fix sample resource path resolution (#3952)
aed8858
@westey-m
westey (westey-m) removed this pull request from the merge queue due to a manual request Feb 17, 2026
@westey-m
westey (westey-m) added this pull request to the merge queue Feb 17, 2026
Merged via the queue into microsoft:main with commit dc6d0bc Feb 17, 2026
21 checks passed
This was referenced Feb 23, 2026
Closed
Closed
Closed
Closed
Closed
@westey-m
westey (westey-m) deleted the samples-resource-path-fix branch February 25, 2026 13:55
This was referenced Feb 25, 2026
Closed
Closed
Closed
Open
This was referenced Mar 9, 2026
Closed
Open
Closed
This was referenced Mar 16, 2026
Merged
Closed
Open
Closed
Open
Closed
Closed
Closed
Merged
Closed
This was referenced Apr 6, 2026
Closed
Open
Open
@dependabot dependabot Bot mentioned this pull request Apr 24, 2026
Merged
This was referenced May 2, 2026
Closed
Closed
This was referenced May 9, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced May 18, 2026
Closed
Closed
This was referenced Jun 6, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jun 24, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jul 15, 2026
Open

This branch was previously deployed

1 inactive deployment
integration — d99155e3 Deployed Feb 16, 2026 by westey-m via dotnet-build-and-test (net472, windows-latest, Release, true, integration) #11931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rogerbarreto Roger Barreto (rogerbarreto) rogerbarreto approved these changes
@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes

Assignees

No one assigned

Labels

.NET Usage: [Issues, PRs], Target: .Net

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@westey-m @rogerbarreto @SergeyMenshykh @markwallace-microsoft