Visitar URL original
.NET: Revert ".NET: Support hosted code interpreter for skill script execution" by SergeyMenshykh · Pull Request #4385 · microsoft/agent-framework · GitHub
Skip to content

.NET: Revert ".NET: Support hosted code interpreter for skill script execution" - #4385

Merged
SergeyMenshykh merged 1 commit into
mainfrom
revert-4192-script-execution-by-code-interpreter
Mar 2, 2026
Merged

.NET: Revert ".NET: Support hosted code interpreter for skill script execution"#4385
SergeyMenshykh merged 1 commit into
mainfrom
revert-4192-script-execution-by-code-interpreter

Conversation

@SergeyMenshykh

@SergeyMenshykh SergeyMenshykh commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

Reverts #4192 until there's further clarity regarding the design of script executors.

Copilot AI review requested due to automatic review settings March 2, 2026 10:44
@SergeyMenshykh SergeyMenshykh self-assigned this Mar 2, 2026
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs .NET Usage: [Issues, PRs], Target: .Net labels Mar 2, 2026
@github-actions github-actions Bot changed the title Revert ".NET: Support hosted code interpreter for skill script execution" .NET: Revert ".NET: Support hosted code interpreter for skill script execution" Mar 2, 2026
Copilot AI reviewed Mar 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the earlier .NET “hosted code interpreter” script-execution support for Agent Skills while keeping the core file-based skills provider behavior.

Changes:

  • Removes hosted code interpreter script-execution types, options, tests, and the Step02 sample.
  • Updates FileAgentSkillsProvider to use composite-format ({0}) prompt templating and adds validation for custom templates.
  • Renames/internalizes some skills-loading implementation types (frontmatter/skill/loader) consistent with the revert.

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/HostedCodeInterpreterFileAgentSkillScriptExecutorTests.cs Removes tests for the hosted code interpreter script executor.
dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/FileAgentSkillsProviderTests.cs Switches custom prompt template placeholder to {0} and adds invalid-template constructor test.
dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/FileAgentSkillScriptExecutorTests.cs Removes integration tests for script executor wiring into the provider.
dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/FileAgentSkillLoaderTests.cs Updates frontmatter type usage and removes tests tied to the reverted resource parsing behavior.
dotnet/src/Microsoft.Agents.AI/Skills/SkillFrontmatter.cs Renames/replaces the prior frontmatter type with an internal SkillFrontmatter.
dotnet/src/Microsoft.Agents.AI/Skills/HostedCodeInterpreterFileAgentSkillScriptExecutor.cs Removes hosted code interpreter executor implementation.
dotnet/src/Microsoft.Agents.AI/Skills/FileAgentSkillsProviderOptions.cs Removes script-executor option and documents {0} placeholder format.
dotnet/src/Microsoft.Agents.AI/Skills/FileAgentSkillsProvider.cs Removes executor/tool merging logic; updates default prompt template and custom template handling.
dotnet/src/Microsoft.Agents.AI/Skills/FileAgentSkillScriptExecutor.cs Removes script executor abstraction.
dotnet/src/Microsoft.Agents.AI/Skills/FileAgentSkillScriptExecutionDetails.cs Removes script execution details model.
dotnet/src/Microsoft.Agents.AI/Skills/FileAgentSkillScriptExecutionContext.cs Removes script execution context model.
dotnet/src/Microsoft.Agents.AI/Skills/FileAgentSkillLoader.cs Internalizes loader, adjusts resource link regex, and internalizes resource read API.
dotnet/src/Microsoft.Agents.AI/Skills/FileAgentSkill.cs Internalizes the skill model and updates it to use SkillFrontmatter.
dotnet/samples/02-agents/AgentSkills/README.md Removes reference to the reverted Step02 sample.
dotnet/samples/02-agents/AgentSkills/Agent_Step02_ScriptExecutionWithCodeInterpreter/skills/password-generator/scripts/generate.py Deletes script resource from the removed Step02 sample.
dotnet/samples/02-agents/AgentSkills/Agent_Step02_ScriptExecutionWithCodeInterpreter/skills/password-generator/references/PASSWORD_GUIDELINES.md Deletes reference doc from the removed Step02 sample.
dotnet/samples/02-agents/AgentSkills/Agent_Step02_ScriptExecutionWithCodeInterpreter/skills/password-generator/SKILL.md Deletes the sample skill definition for the removed Step02 sample.
dotnet/samples/02-agents/AgentSkills/Agent_Step02_ScriptExecutionWithCodeInterpreter/README.md Deletes Step02 sample documentation.
dotnet/samples/02-agents/AgentSkills/Agent_Step02_ScriptExecutionWithCodeInterpreter/Program.cs Deletes Step02 sample program.
dotnet/samples/02-agents/AgentSkills/Agent_Step02_ScriptExecutionWithCodeInterpreter/Agent_Step02_ScriptExecutionWithCodeInterpreter.csproj Deletes Step02 sample project.
dotnet/samples/02-agents/AgentSkills/Agent_Step01_BasicSkills/Program.cs Removes a warning comment block from the sample.
dotnet/agent-framework-dotnet.slnx Removes Step02 sample project reference from the solution.

Comment thread dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/FileAgentSkillsProviderTests.cs Resolved
Comment thread dotnet/src/Microsoft.Agents.AI/Skills/FileAgentSkillsProvider.cs Resolved
@SergeyMenshykh
SergeyMenshykh enabled auto-merge March 2, 2026 11:03
@SergeyMenshykh
SergeyMenshykh added this pull request to the merge queue Mar 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 2, 2026
@SergeyMenshykh
SergeyMenshykh added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 26cef55 Mar 2, 2026
25 checks passed
This was referenced Mar 4, 2026
Open
Closed
Closed
Closed
Closed
This was referenced Mar 13, 2026
Closed
Closed
Closed
Closed
Open
This was referenced Apr 13, 2026
Closed
Closed
Closed
This was referenced Apr 20, 2026
Closed
Closed
Merged
This was referenced Apr 28, 2026
Closed
Closed
This was referenced May 6, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 15, 2026
Closed
Closed
Closed
Closed
This was referenced May 22, 2026
Closed
Open
This was referenced May 29, 2026
Closed
Closed
This was referenced Jun 6, 2026
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jun 24, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jul 15, 2026
Open

This branch was previously deployed

1 inactive deployment
integration — c0b88f28 Deployed Mar 2, 2026 by SergeyMenshykh via dotnet-build-and-test (net472, windows-latest, Release, true, integration) #13420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@rogerbarreto Roger Barreto (rogerbarreto) rogerbarreto approved these changes
@westey-m westey (westey-m) westey-m approved these changes

Assignees

@SergeyMenshykh SergeyMenshykh

Labels

documentation Usage: [Issues, PRs], Target: documentation in the code base and learn docs .NET Usage: [Issues, PRs], Target: .Net

Projects

Agent Framework
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SergeyMenshykh @rogerbarreto @westey-m @markwallace-microsoft