Visitar URL original
Python: fix: preserve synthetic compaction summaries by Namraa310806 · Pull Request #7944 · microsoft/agent-framework · GitHub
Skip to content

Python: fix: preserve synthetic compaction summaries - #7944

Merged
Evan Mattson (moonbox3) merged 17 commits into
microsoft:mainfrom
Namraa310806:fix/compaction-before-run-summary
Sep 15, 2026
Merged

Python: fix: preserve synthetic compaction summaries#7944
Evan Mattson (moonbox3) merged 17 commits into
microsoft:mainfrom
Namraa310806:fix/compaction-before-run-summary

Conversation

@Namraa310806

@Namraa310806 Patel Namraa (Namraa310806) commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Motivation & Context

CompactionProvider.before_run can lose synthetic summary messages created by replacement-based compaction strategies such as ToolResultCompactionStrategy and SummarizationStrategy.

These strategies create new Message objects to replace messages that are excluded during compaction. However, before_run was only filtering the existing messages in context.context_messages using object identity. Since the newly created summary messages were not part of those original source lists, they were silently discarded during reconciliation.

This could cause the original tool results or conversation history to be removed without retaining the summary that was supposed to replace them.

Fixes #7943.

Description & Review Guide

  • What are the major changes?

    • Updated CompactionProvider.before_run to track the source of existing messages before running the compaction strategy.
    • Rebuild the context.context_messages buckets from the projected message list after compaction instead of only filtering the original buckets.
    • This allows newly created synthetic summary messages to be preserved.
    • Added regression coverage for ToolResultCompactionStrategy and SummarizationStrategy.

  • What is the impact of these changes?

    • Synthetic summary messages created during before_strategy compaction are no longer silently dropped.
    • Compacted tool results and summarized conversation history are preserved in the session context.
    • This is a bug fix and does not change the public API.

  • What do you want reviewers to focus on?

    • The reconciliation logic in CompactionProvider.before_run, especially how existing messages and newly created synthetic messages are assigned back to context.context_messages.
    • The regression tests verifying that both tool-result summaries and summarization messages survive the before_run reconciliation.

Related Issue

Fixes #7943

Contribution Checklist

  • The code builds clean without any errors or warnings
  • All unit tests pass, and I have added new tests where possible
  • The PR follows the Contribution Guidelines
  • This PR is linked to an issue and there is no other open PR for this issue.
  • This is not a breaking change.

Copilot AI balanced review requested due to automatic review settings August 29, 2026 04:54
Copilot AI reviewed Aug 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@agent-framework-automation agent-framework-automation Bot added the python Usage: [Issues, PRs], Target: Python label Aug 29, 2026
@github-actions github-actions Bot changed the title fix: preserve synthetic compaction summaries Python: fix: preserve synthetic compaction summaries Aug 29, 2026
moonbox3
Evan Mattson (moonbox3) reviewed Aug 31, 2026
View reviewed changes
Comment thread python/packages/core/agent_framework/_compaction.py Resolved
@Namraa310806
Merge upstream/main into fix/compaction-before-run-summary
e411bc6 
Resolved merge conflict in _compaction.py by combining both approaches:
- Use upstream's _run_compaction_strategy helper for consistency
- Preserve local branch's source tracking logic for message attribution after compaction
@JHf0912 JHf0912 mentioned this pull request Sep 5, 2026
Merged
moonbox3
Evan Mattson (moonbox3) reviewed Sep 9, 2026
View reviewed changes
Comment thread python/packages/core/agent_framework/_compaction.py Resolved
@eavanvalkenburg

Eduard van Valkenburg (eavanvalkenburg) commented Sep 14, 2026

Copy link
Copy Markdown
Member

Thanks for the update. Before this is ready, could you please:

Once those are addressed, please re-request review. Thanks!

@moonbox3

Evan Mattson (moonbox3) commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Please fix the failing unit tests.

@moonbox3

Evan Mattson (moonbox3) commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Please fix the failing unit tests.

This was a flaky unit test I fixed. No action on your end re: failing unit tests.

@moonbox3
Evan Mattson (moonbox3) added this pull request to the merge queue Sep 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 15, 2026
@moonbox3
Evan Mattson (moonbox3) added this pull request to the merge queue Sep 15, 2026
Merged via the queue into microsoft:main with commit e07c6bc Sep 15, 2026
40 checks passed
@Namraa310806
Patel Namraa (Namraa310806) deleted the fix/compaction-before-run-summary branch October 13, 2026 14:16

This branch was previously deployed

1 inactive deployment
github-app-auth — 7d81922d Deployed Sep 15, 2026 by moonbox3 via add_label #22820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@moonbox3 Evan Mattson (moonbox3) moonbox3 approved these changes
@chetantoshniwal chetantoshniwal Awaiting requested review from chetantoshniwal
@eavanvalkenburg Eduard van Valkenburg (eavanvalkenburg) Awaiting requested review from eavanvalkenburg eavanvalkenburg is a code owner
@TaoChenOSU Tao Chen (TaoChenOSU) Awaiting requested review from TaoChenOSU
@giles17 Giles Odigwe (giles17) Awaiting requested review from giles17
@jpalvarezl Jose Alvarez (jpalvarezl) Awaiting requested review from jpalvarezl jpalvarezl is a code owner
@SergeyMenshykh SergeyMenshykh Awaiting requested review from SergeyMenshykh SergeyMenshykh is a code owner
@rogerbarreto Roger Barreto (rogerbarreto) Awaiting requested review from rogerbarreto rogerbarreto is a code owner
@westey-m westey (westey-m) Awaiting requested review from westey-m westey-m is a code owner

Assignees

No one assigned

Labels

python Usage: [Issues, PRs], Target: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python: [Bug]: CompactionProvider.before_run drops synthetic summary messages created by compaction strategies

4 participants

@Namraa310806 @eavanvalkenburg @moonbox3