Visitar URL original
Add docs for ASPIREAZURE004-007 diagnostics by eerhardt · Pull Request #2138 · microsoft/aspire.dev · GitHub
Skip to content

Add docs for ASPIREAZURE004-007 diagnostics - #2138

Open
Eric Erhardt (eerhardt) wants to merge 1 commit into
release/17.0from
eerhardt-docs-new-diagnostic-ids
Open

Eric Erhardt (eerhardt) wants to merge 1 commit into
release/17.0from
eerhardt-docs-new-diagnostic-ids

Conversation

@eerhardt

Copy link
Copy Markdown
Member

Summary

Adds diagnostic pages for the four experimental IDs introduced in microsoft/aspire#22217, which moved non-networking Azure APIs off ASPIREAZURE003:

  • ASPIREAZURE004: AzureResourceInfrastructure.BicepExtensions
  • ASPIREAZURE005: IBicepOutputReferenceProvider
  • ASPIREAZURE006: ManagedIdentityRequiredAnnotation
  • ASPIREAZURE007: TenantScopedResourceAnnotation

Each page follows the existing 17.0 diagnostic page format and covers the default compiler message, an explanation, a C# example, and suppression options. The APIs aren't exported to TypeScript AppHosts, so the pages have no TypeScript tabs. Also adds the IDs to the diagnostics overview table and the reference sidebar.

Third-party links and affiliations

None

Validation

  • Measured seoTitle and description lengths manually. All fall within the 30-65 / 80-200 ranges that tests/unit/seo-lengths.vitest.test.ts enforces. The vitest suite wasn't run locally because dependencies aren't installed in this worktree, so CI covers it.
  • Checked API names and semantics against the upstream source in [release/17.0] Address API review feedback from #22185 aspire#22217.
  • Didn't compile the C# examples. Reviewers should confirm the 006 and 007 snippets.

Document the new experimental diagnostic IDs added in microsoft/aspire#22217 and add them to the diagnostics overview table and sidebar.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Author-requested compilation and suppression checks for the ASPIREAZURE006/007 C# examples remain unverified because the review environment lacks the required dependencies.

No open issues 🎉

What changed in this PR

Adds documentation for ASPIREAZURE004–ASPIREAZURE007, covering the non-networking Azure APIs moved off ASPIREAZURE003 for Aspire 17.0.

Changes:

  • Adds four diagnostic pages with explanations, C# examples, and suppression options.
  • Notes that the affected APIs aren't available to TypeScript AppHosts.
  • Links the pages from the diagnostics overview and reference sidebar.
File Description
src/​frontend/​src/​content/​docs/​diagnostics/​overview.mdx Adds the four diagnostic IDs to the overview table.
src/​frontend/​src/​content/​docs/​diagnostics/​aspireazure007.mdx Documents the experimental tenant-scoped resource annotation.
src/​frontend/​src/​content/​docs/​diagnostics/​aspireazure006.mdx Documents the experimental managed identity requirement annotation.
src/​frontend/​src/​content/​docs/​diagnostics/​aspireazure005.mdx Documents the experimental Bicep output reference provider interface.
src/​frontend/​src/​content/​docs/​diagnostics/​aspireazure004.mdx Documents the experimental Bicep extension declarations property.
src/​frontend/​config/​sidebar/​reference.topics.ts Adds sidebar entries for all four diagnostic pages.

Review effort: Balanced

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #2138. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #2138 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

@IEvangelist

Copy link
Copy Markdown
Member

Eric Erhardt (@eerhardt) did you create AKA links for these yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants