Repository navigation
Conversation
Author
|
@microsoft-github-policy-service agree |
takuto-NA
marked this pull request as ready for review
November 9, 2026 11:09
Contributor
|
takuto-NA thanks for the contribution! 🙏 I'll add comments inline. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filleting short, nearly collinear lines currently returns
nulleven when the tangent points fit inside both segments. With arcs, selecting guides from a radius-sized sample can also produce a tangent reversal or trim the wrong part of a major arc.Determine offset guides from endpoint tangents, using signed curvature for equal-tangent cusps. Intersect their supporting lines/circles without fixed-unit coordinate rounding, then accept only candidates whose tangent points stay within both original paths, connect accurately, and preserve tangent direction. Honor
pointMatchingDistanceand reject unsupported, nonfinite, or degenerate inputs without mutation.For example, these unit-length segments can accommodate a radius-2 fillet; the current reference-circle check rejects it:
Validation
npm test, including every workspace build, 158 tests, build tools, and documentation generation, passed on Windows with Node 20.20.2 / npm 10.8.2 and Node 22.23.4 / npm 10.9.9.MAKERJS_FILLET_STRESS_CASES=100000 npm run test-fillet --workspace=makerjspassed: 34 test groups, including 1,600,000 deterministic generated path pairs.This remains a local corner operation; it does not check collisions against unrelated paths. Numerically ill-conditioned candidates can return
nullrather than an inaccurate fillet. The contributor will handle CLA consent separately.