Repository navigation
docs: document optimization disk recommendation summary - #3936
Open
David Billiot (WeAreResilience) wants to merge 1 commit into
Open
David Billiot (WeAreResilience) wants to merge 1 commit into
David Billiot (WeAreResilience) wants to merge 1 commit into
Conversation
David Billiot (WeAreResilience)
requested a review
from a team
as a code owner
October 13, 2026 18:50
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Thank you for your contribution David Billiot (@WeAreResilience)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately reflects the existing implementation and fulfills the linked issue.
0 open findings
What changed in this PR
Closes #3935 by documenting Azure Optimization’s unattached-disk recommendation summary and improving tool discovery.
Changes:
- Documents the
diskRecommendationSummaryresponse. - Adds an unattached-disk e2e prompt.
- Adds Azure Optimization examples and service-list coverage.
| File | Description |
|---|---|
servers/Azure.Mcp.Server/README.md |
Adds Optimization discovery content. |
servers/Azure.Mcp.Server/docs/e2eTestPrompts.md |
Adds summary-focused test prompt. |
servers/Azure.Mcp.Server/docs/azmcp-commands.md |
Documents the summary response contract. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
Gentle ping on this docs change: it's ready for review whenever someone has a moment. |
David Billiot (WeAreResilience)
force-pushed
the
fix-3935
branch
from
November 11, 2026 14:43
8833852 to
510682c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3935
PR #3899 added a
diskRecommendationSummaryoutput tooptimization recommendation list, but the docs didn't describe it, and the Optimization toolset had no README entry.Changes (docs only, all under
servers/Azure.Mcp.Server/):docs/azmcp-commands.md: note underoptimization recommendation listthat unattached-disk recommendations are returned as onediskRecommendationSummaryobject (message,unattachedDiskCount,subscriptionIds,actionUrl) instead of individual rows. Field names matchtools/Azure.Mcp.Tools.Optimization/src/Models/DiskRecommendationSummary.cson current main.docs/e2eTestPrompts.md: add anoptimization_recommendation_listprompt about unattached disks.README.md: add an "Azure Optimization" example-prompt section and an entry in "Complete List of Supported Azure Services", placed alphabetically.No code changes. Rebased onto current main on Nov 11; merges cleanly.