Visitar URL original
Add PreferAssertFailOverAlwaysFalseConditionsAnalyzer by Youssef1313 · Pull Request #2799 · microsoft/testfx · GitHub
Skip to content

Add PreferAssertFailOverAlwaysFalseConditionsAnalyzer - #2799

Merged
Amaury Levé (Evangelink) merged 4 commits into
microsoft:mainfrom
Youssef1313:always-false-analyzer
May 3, 2024
Merged

Add PreferAssertFailOverAlwaysFalseConditionsAnalyzer#2799
Amaury Levé (Evangelink) merged 4 commits into
microsoft:mainfrom
Youssef1313:always-false-analyzer

Conversation

@Youssef1313

@Youssef1313 Youssef Fahmy (Youssef1313) commented May 2, 2024

Copy link
Copy Markdown
Member

Fixes #2753

Evangelink
Amaury Levé (Evangelink) reviewed May 3, 2024
View reviewed changes

@Evangelink Amaury Levé (Evangelink) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see you here Youssef Fahmy (@Youssef1313)! I added a few comments/nits

Comment thread src/Analyzers/MSTest.Analyzers/AnalyzerReleases.Unshipped.md Resolved
Comment thread src/Analyzers/MSTest.Analyzers/PreferAssertFailOverAlwaysFalseConditionsAnalyzer.cs Resolved
Comment thread ...itTests/MSTest.Analyzers.UnitTests/PreferAssertFailOverAlwaysFalseConditionsAnalyzerTests.cs Resolved
Comment thread ...itTests/MSTest.Analyzers.UnitTests/PreferAssertFailOverAlwaysFalseConditionsAnalyzerTests.cs Resolved
Comment thread ...itTests/MSTest.Analyzers.UnitTests/PreferAssertFailOverAlwaysFalseConditionsAnalyzerTests.cs Resolved
Youssef Fahmy (Youssef1313) and others added 3 commits May 3, 2024 12:20
@Youssef1313 @Evangelink
Apply suggestions from code review
8a8f533 
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
@Youssef1313 @Evangelink
Apply suggestions from code review
571d16f 
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
@Youssef1313
Update testbaseline.txt
83ba3ec
@Youssef1313

Youssef Fahmy (Youssef1313) commented May 3, 2024

Copy link
Copy Markdown
Member Author

Nice to see you here Youssef Fahmy (@Youssef1313)! I added a few comments/nits

Thank you! and thanks for the review!

I addressed the review comments and updated testsbaseline.txt. Let's see if CI will be green now.

@Youssef1313
Youssef Fahmy (Youssef1313) marked this pull request as ready for review May 3, 2024 10:52
Evangelink
Amaury Levé (Evangelink) approved these changes May 3, 2024
View reviewed changes

@Evangelink Amaury Levé (Evangelink) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution Youssef Fahmy (@Youssef1313) :shipit:

@Evangelink
Amaury Levé (Evangelink) merged commit 5639216 into microsoft:main May 3, 2024
@Youssef1313
Youssef Fahmy (Youssef1313) deleted the always-false-analyzer branch May 3, 2024 18:31
@Evangelink Amaury Levé (Evangelink) mentioned this pull request May 7, 2024
Merged
This was referenced Jul 22, 2025
Closed
Merged
Closed
Closed
Closed
This was referenced Jul 29, 2025
Closed
Closed
Merged
Closed
Closed
Open
Open
Merged
Closed
Closed
Open
Closed
This was referenced Oct 29, 2025
Closed
Closed
Closed
Closed
This was referenced Nov 5, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 12, 2025
Closed
Closed
Merged
Closed
Closed
Closed
This was referenced Nov 19, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 10, 2025
Closed
Open
Closed
This was referenced Jan 18, 2026
Merged
Open
Merged
@dependabot dependabot Bot mentioned this pull request Jun 16, 2026
Merged
@dependabot dependabot Bot mentioned this pull request Jul 13, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Sep 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evangelink Amaury Levé (Evangelink) Evangelink approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prefer Assert.Fail over always failing conditions

2 participants

@Youssef1313 @Evangelink