Visitar URL original
[trianglemeshdistance, mujoco] add trianglemeshdistance new port. update mujoco to v3.3.7. by talregev · Pull Request #48566 · microsoft/vcpkg · GitHub
Skip to content

[trianglemeshdistance, mujoco] add trianglemeshdistance new port. update mujoco to v3.3.7. - #48566

Merged
Billy O'Neal (BillyONeal) merged 1 commit into
microsoft:masterfrom
talregev:TalR/mujoco
Dec 5, 2025
Merged

[trianglemeshdistance, mujoco] add trianglemeshdistance new port. update mujoco to v3.3.7.#48566
Billy O'Neal (BillyONeal) merged 1 commit into
microsoft:masterfrom
talregev:TalR/mujoco

Conversation

@talregev

@talregev talregev commented Nov 29, 2025

Copy link
Copy Markdown
Contributor
  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@talregev talregev changed the title [trianglemeshdistance, mujoco ] add trianglemeshdistance new port. update mujoco to v3.3.7. [trianglemeshdistance, mujoco] add trianglemeshdistance new port. update mujoco to v3.3.7. Nov 29, 2025
@talregev
talregev force-pushed the TalR/mujoco branch 2 times, most recently from bf8ae14 to f039aef Compare November 29, 2025 17:49
@talregev
talregev marked this pull request as ready for review November 29, 2025 18:01
@talregev

talregev commented Nov 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The ci if failing due the baseline regressions from master ci.

@talregev
talregev force-pushed the TalR/mujoco branch 2 times, most recently from bdaf24c to 3b447f9 Compare December 1, 2025 20:54
@talregev

talregev commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

Billy O'Neal (@BillyONeal) Can you take a look? :)

BillyONeal
Billy O'Neal (BillyONeal) reviewed Dec 3, 2025
View reviewed changes
Comment thread ports/mujoco/fix_dependencies.patch Outdated
Comment on lines +155 to +158
+ GIT_REPO
+ https://github.com/InteractiveComputerGraphics/TriangleMeshDistance.git
+ GIT_TAG
+ ${MUJOCO_DEP_VERSION_TriangleMeshDistance}

@BillyONeal Billy O'Neal (BillyONeal) Dec 2, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should not be necessary since we expect the port to always provide it right?

@talregev talregev Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what will happen if I do not give the tag. If you take a look, other library in this patch also I did the same i put on system on and provide a tag, but it never take it from the internet.

@talregev talregev Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It hard to see, because you don't see the full functions from the patch:
https://github.com/google-deepmind/mujoco/blob/3.3.7/cmake/MujocoDependencies.cmake

@talregev talregev Dec 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try locally to remove GIT_REPO and GIT_TAG and it working.

BillyONeal
Billy O'Neal (BillyONeal) approved these changes Dec 5, 2025
View reviewed changes

@BillyONeal Billy O'Neal (BillyONeal) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BillyONeal
Billy O'Neal (BillyONeal) merged commit 40337e6 into microsoft:master Dec 5, 2025
17 checks passed
@talregev
talregev deleted the TalR/mujoco branch December 5, 2025 06:47
@talregev talregev mentioned this pull request Dec 5, 2025
Merged
Ian Reinhart Geiser (geiseri) pushed a commit to geiseri/vcpkg that referenced this pull request Dec 18, 2025
@talregev @geiseri
[trianglemeshdistance, mujoco] add trianglemeshdistance new port. upd…
71b4a75 
…ate mujoco to v3.3.7. (microsoft#48566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal Billy O'Neal (BillyONeal) BillyONeal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@talregev @BillyONeal