Visitar URL original
chore: update electron@39.8.7 by deepak1556 · Pull Request #308959 · microsoft/vscode · GitHub
Skip to content

chore: update electron@39.8.7 - #308959

Merged
Robo (deepak1556) merged 4 commits into
mainfrom
robo/update_electron
Apr 10, 2026
Merged

chore: update electron@39.8.7#308959
Robo (deepak1556) merged 4 commits into
mainfrom
robo/update_electron

Conversation

@deepak1556

@deepak1556 Robo (deepak1556) commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Refs https://releases.electronjs.org/release/compare/v39.8.5/v39.8.7

@deepak1556 Robo (deepak1556) added this to the 1.116.0 milestone Apr 10, 2026
@deepak1556 Robo (deepak1556) self-assigned this Apr 10, 2026
Copilot AI review requested due to automatic review settings April 10, 2026 07:20
Copilot AI reviewed Apr 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s Electron dependency to 39.8.7 and aligns VS Code/Copilot code with upstream TLS API changes (removing usage/telemetry around tls.getSystemCACertificatesErrors).

Changes:

  • Bump Electron from 39.8.5 → 39.8.7 and update associated manifests/locks/checksums.
  • Remove additional certificates telemetry field and related helper logic tied to the removed TLS errors API.
  • Simplify Copilot’s “show Node.js system certificate errors” diagnostics command implementation.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vs/workbench/api/node/proxyResolver.ts Removes nodeSystemCertErrors telemetry + helper that depended on the removed TLS errors API.
extensions/copilot/src/extension/log/vscode-node/loggingActions.ts Drops collection/display of TLS system CA certificate errors in the diagnostics command.
package.json Updates Electron version to 39.8.7.
package-lock.json Updates Electron lockfile entry to 39.8.7.
cgmanifest.json Updates Electron component metadata (tag/hash/version) to 39.8.7.
build/checksums/electron.txt Refreshes Electron/Chromedriver/FFmpeg/etc. checksums for 39.8.7 artifacts.
.npmrc Updates Electron build target/version and ms_build_id.

Comment thread extensions/copilot/src/extension/log/vscode-node/loggingActions.ts Resolved
chrmarti
Christof Marti (chrmarti) reviewed Apr 10, 2026
View reviewed changes

@chrmarti Christof Marti (chrmarti) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command could be remove, otherwise LGTM, thanks!

Comment thread extensions/copilot/src/extension/log/vscode-node/loggingActions.ts Resolved
@deepak1556
Robo (deepak1556) marked this pull request as ready for review April 10, 2026 07:41
@deepak1556
Robo (deepak1556) enabled auto-merge (squash) April 10, 2026 07:41
@deepak1556
Robo (deepak1556) merged commit c88afda into main Apr 10, 2026
26 checks passed
@deepak1556
Robo (deepak1556) deleted the robo/update_electron branch April 10, 2026 08:33
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@chrmarti Christof Marti (chrmarti) chrmarti left review comments
+1 more reviewer
@joaomoreno João Moreno (joaomoreno) joaomoreno approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@deepak1556 Robo (deepak1556)

Labels

None yet

Projects

None yet

Milestone

1.116.0

Development

Successfully merging this pull request may close these issues.

4 participants

@deepak1556 @joaomoreno @chrmarti