Visitar URL original
Better floating comment widget positioning in multidiff editor by alexr00 · Pull Request #347925 · microsoft/vscode · GitHub
Skip to content

Better floating comment widget positioning in multidiff editor - #347925

Merged
Alex Ross (alexr00) merged 2 commits into
mainfrom
alexr00/decisive-bovid
Nov 13, 2026
Merged

Better floating comment widget positioning in multidiff editor#347925
Alex Ross (alexr00) merged 2 commits into
mainfrom
alexr00/decisive-bovid

Conversation

@alexr00

@alexr00 Alex Ross (alexr00) commented Nov 12, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI balanced review requested due to automatic review settings November 12, 2026 15:56
@alexr00
Alex Ross (alexr00) enabled auto-merge (squash) November 12, 2026 15:56
@alexr00 Alex Ross (alexr00) self-assigned this Nov 12, 2026
Copilot AI reviewed Nov 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Multi-diff comment threads can exceed their visible pane and clip reply controls, while reveal requests made before layout growth can leave the requested thread out of view.

2 open issues
What changed in this PR

Improves floating comment positioning in VS Code’s multi-diff editor by adding space for widgets that extend below file content and keeping below-code placement aligned to the right edge.

Changes:

  • Adds dynamically sized trailing space for floating comments in multi-diff items.
  • Connects widget sizing, rendering and cleanup to that space.
  • Right-aligns the below-code fallback and updates placement tests.
File Description
src/​vs/​workbench/​contrib/​comments/​test/​browser/​commentThreadFloatingWidget.test.ts Updates expected positions for right-aligned fallback placement.
src/​vs/​workbench/​contrib/​comments/​browser/​commentThreadFloatingWidgetRoom.ts Adds a view-zone manager that reserves space below editor content.
src/​vs/​workbench/​contrib/​comments/​browser/​commentThreadFloatingWidgetLayout.ts Keeps widgets at the right edge when placed below code.
src/​vs/​workbench/​contrib/​comments/​browser/​commentThreadFloatingWidget.ts Integrates room-aware sizing, placement and lifecycle updates.
src/​vs/​workbench/​contrib/​comments/​browser/​commentsController.ts Creates and exposes the room manager for multi-diff editors.

Review effort: Balanced

Comment thread src/vs/workbench/contrib/comments/browser/commentThreadFloatingWidget.ts Resolved
Comment thread src/vs/workbench/contrib/comments/browser/commentThreadFloatingWidgetRoom.ts Resolved
@alexr00
Alex Ross (alexr00) marked this pull request as draft November 12, 2026 17:04
auto-merge was automatically disabled November 12, 2026 17:04

Pull request was converted to draft

@alexr00
Alex Ross (alexr00) marked this pull request as ready for review November 13, 2026 09:42
@alexr00
Alex Ross (alexr00) enabled auto-merge (squash) November 13, 2026 09:42
@alexr00
Alex Ross (alexr00) merged commit 86c9022 into main Nov 13, 2026
93 of 96 checks passed
@alexr00
Alex Ross (alexr00) deleted the alexr00/decisive-bovid branch November 13, 2026 10:35
@vs-code-engineering vs-code-engineering Bot added this to the 1.147.0 milestone Nov 13, 2026
@alexr00 Alex Ross (alexr00) mentioned this pull request Nov 13, 2026
Merged
Christopher Montevirgen (toperux) pushed a commit to toperux/vscode that referenced this pull request Nov 13, 2026
@alexr00
CCR for microsoft#347925 (microsoft#348129)
7ba955d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@deepak1556 Robo (deepak1556) deepak1556 approved these changes
@dbaeumer Dirk Bäumer (dbaeumer) dbaeumer left review comments

Assignees

@alexr00 Alex Ross (alexr00)

Labels

None yet

Projects

None yet

Milestone

1.147.0

Development

Successfully merging this pull request may close these issues.

4 participants

@alexr00 @deepak1556 @dbaeumer