Repository navigation
Update repo install instruction for Fedora 45 and newer - #10638
Open
Rostislav Krasny (rostidev) wants to merge 1 commit into
Open
Rostislav Krasny (rostidev) wants to merge 1 commit into
Rostislav Krasny (rostidev) wants to merge 1 commit into
Conversation
Alok Pandey (alok-108)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for looking into Fedora 45+ DNF5 changes, Rostislav Krasny (@rostidev)!
I don't think we should instruct users to write manually to /usr/share/dnf5/repos.d/vscode.repo:
/usr/share/dnf5/repos.dis for distro/RPM-packaged repo files, not manual user configs: In Fedora 45+, default OS repository definitions (e.g.,fedora.repo,fedora-updates.repo) were moved out of/etcinto/usr/share/dnf5/repos.dto cleanly separate distribution-managed files from local administration./etc/yum.repos.dremains the standard path for manually added third-party repos: DNF5'sreposdirconfiguration continues to include/etc/yum.repos.d(listed first, and wherednf5 config-manager addrepowrites by default), so the existing/etc/yum.repos.d/vscode.repoinstruction continues to work on Fedora 45+ out of the box.- Immutable/atomic variants & FHS: Writing local configuration into
/usrgoes against Filesystem Hierarchy Standard conventions and will fail on atomic Fedora variants (such as Silverblue or Kinoite) where/usris mounted read-only.
Because /etc/yum.repos.d/vscode.repo is still supported and recommended for manually added third-party repositories in Fedora 45+, keeping the single /etc/yum.repos.d/vscode.repo instruction avoids unnecessary branching and prevents users from writing into /usr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.