Repository navigation
Fix malformed issue links in overview HTML - #9025
strawberry-little-bear wants to merge 4 commits into
Conversation
|
strawberry-little-bear, thanks for the PR! Could you just accept the CLA? |
|
@microsoft-github-policy-service agree |
|
/AzurePipelines run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Head branch was pushed to by a user without write access
| assert.strictEqual(events[0].event, EventType.Merged); | ||
| assert.strictEqual(events[0].mergeRef, 'main'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Why are these tests now deleted?
There was a problem hiding this comment.
That deletion was my mistake. When I pushed 1ee7b70 I only meant to add the bodyHTML assertion in the issue link test, but I ended up uploading a version of the file that had lost the parseCombinedTimelineEvents block along with the GraphQL and GitHubRepository imports it needs, so roughly 48 lines went missing.
Everything is back in c5f1606. The two parseCombinedTimelineEvents tests are at lines 125-162 of src/test/github/utils.test.ts with the imports restored, so the file is now unchanged apart from the bodyHTML assertion. Sorry for the churn, could you take another look at the current head?
1ee7b70 to
f6dfcff
Compare
f6dfcff to
d3fcc40
Compare
d3fcc40 to
c5f1606
Compare
|
/AzurePipelines run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
|
/AzurePipelines run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Fixes #9022
Issue links in overview HTML were rewritten with one extra
"at the end of the generatedhrefvalue. Pull request links in the same code path did not have this extra character, so the two cases behaved differently and issue links produced malformed HTML.This removes the stray quote and adds a regression test covering an overview containing both an issue link and a pull request link.
Tests:
git diff --checkpassed.npm ci --ignore-scriptslocally because the workspace drive ran out of space during dependency extraction, sonpm run compile:testandnpm run test:scriptswere not run locally.