Visitar URL original
Build isolated test assets for single TFM instead of 7 by nohwnd · Pull Request #15517 · microsoft/vstest · GitHub
Skip to content

Build isolated test assets for single TFM instead of 7 - #15517

Merged
Jakub Jareš (nohwnd) merged 1 commit into
microsoft:mainfrom
nohwnd:optimize-isolated-test-asset-single-tfm
Mar 19, 2026
Merged

Build isolated test assets for single TFM instead of 7#15517
Jakub Jareš (nohwnd) merged 1 commit into
microsoft:mainfrom
nohwnd:optimize-isolated-test-asset-single-tfm

Conversation

@nohwnd

@nohwnd Jakub Jareš (nohwnd) commented Mar 19, 2026

Copy link
Copy Markdown
Member

Summary

\GetIsolatedTestAsset\ now takes a \ argetFramework\ parameter and rewrites the csproj to build only that TFM. Previously, test assets built for all 7 target frameworks (
et462;net472;net48;net8.0;net9.0;net10.0;net11.0) even though the test assertions only need output from one.

Before/After (measured)

Test Before After Savings
\MSBuildLoggerCanBeEnabledByBuildPropertyAndDoesNotEatSpecialChars\ 76.1s 14.6s 81%
\RunDotnetTestWithCsprojPassInlineSettings\ 61.7s 14.5s 77%
\MSBuildLoggerCanBeDisabledByEnvironmentVariableProperty\ 82.5s 66.1s 20%

Changes

  • *\AcceptanceTestBase.GetIsolatedTestAsset* — new overload accepts \ argetFramework, rewrites <TargetFrameworks>\ → <TargetFramework>\ in the copied csproj
  • 6 callers updated in \DotnetTestMSBuildOutputTests, \DotnetTestTests, \RunsettingsTests\ to pass
    unnerInfo.TargetFramework\

@nohwnd
Build isolated test assets for single TFM instead of 7
598d42e 
GetIsolatedTestAsset now takes a targetFramework parameter and rewrites
the csproj to build only that TFM. Previously, test assets built for all
7 target frameworks (net462;net472;net48;net8.0;net9.0;net10.0;net11.0)
even though the test assertions only need output from one.

Results on affected tests:
- MSBuildLoggerCanBeEnabledByBuildPropertyAndDoesNotEatSpecialChars: 76s -> 15s
- RunDotnetTestWithCsprojPassInlineSettings: 62s -> 15s
- MSBuildLoggerCanBeDisabledByEnvironmentVariableProperty: 83s -> 66s
- MSBuildLoggerCanBeDisabledByBuildProperty: 50s -> ~15s (estimated)
- RunDotnetTestWithCsproj: 45s -> ~15s (estimated)
- RunSettingsAreLoadedFromProject: 31s -> ~15s (estimated)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 19, 2026 14:51
Copilot AI reviewed Mar 19, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR speeds up acceptance tests by changing isolated test-asset builds to target a single TFM instead of building all multi-target TFMs in the asset project.

Changes:

  • Update AcceptanceTestBase.GetIsolatedTestAsset to accept a targetFramework and rewrite the copied .csproj to build only that TFM.
  • Update acceptance test callers to pass runnerInfo.TargetFramework.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
test/Microsoft.TestPlatform.TestUtilities/AcceptanceTestBase.cs Adds TFM parameter and rewrites copied csproj to single-target before building.
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/RunsettingsTests.cs Updates isolated asset creation call to pass runnerInfo.TargetFramework.
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/DotnetTestTests.cs Updates isolated asset creation calls to pass runnerInfo.TargetFramework.
test/Microsoft.TestPlatform.Acceptance.IntegrationTests/DotnetTestMSBuildOutputTests.cs Updates isolated asset creation calls to pass runnerInfo.TargetFramework.

Comment thread test/Microsoft.TestPlatform.TestUtilities/AcceptanceTestBase.cs Resolved
Comment thread test/Microsoft.TestPlatform.TestUtilities/AcceptanceTestBase.cs Resolved
Comment thread test/Microsoft.TestPlatform.TestUtilities/AcceptanceTestBase.cs Resolved
@nohwnd
Jakub Jareš (nohwnd) enabled auto-merge (squash) March 19, 2026 15:51
@nohwnd
Jakub Jareš (nohwnd) merged commit 9788e88 into microsoft:main Mar 19, 2026
7 checks passed
This was referenced May 26, 2026
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
This was referenced Nov 11, 2026
Open
Open
Closed
Merged
Open
Merged
Open
Closed
Closed
Closed
Closed
Closed
Open
Open
Open
Open
Open
Open
Merged
Closed
Open
Open
Open
Open
Open
Open
Merged
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nohwnd