Visitar URL original
Add `PidsLimit` in swarm Resources. by darkowlzz · Pull Request #33675 · moby/moby · GitHub
Skip to content

Add PidsLimit in swarm Resources. - #33675

Closed
darkowlzz wants to merge 1 commit into
moby:masterfrom
darkowlzz:swarm-service-pidslimit
Closed

darkowlzz wants to merge 1 commit into
moby:masterfrom
darkowlzz:swarm-service-pidslimit

Conversation

@darkowlzz

Copy link
Copy Markdown
Contributor

Refer docker/cli#181

Adds PidsLimit in:

  • swarm.Resources struct
  • swagger.yaml for swarm resources
  • resourcesFromGRPC() and resourcesToGRPC()
  • daemon cluster executor containerConfig.resources()

Signed-off-by: Sunny Gogoi indiasuny000@gmail.com

- What I did

Added PidsLimit to swarm Resources.

- How I did it

Refer commit message.

- Description for the changelog

Add PidsLimit to swarm Resources.

Adds `PidsLimit` in:
  - `swarm.Resources` struct
  - swagger.yaml for swarm resources
  - `resourcesFromGRPC()` and `resourcesToGRPC()`
  - daemon cluster executor `containerConfig.resources()`

Signed-off-by: Sunny Gogoi <indiasuny000@gmail.com>
@darkowlzz darkowlzz changed the title Add PidsLimit to swarm Resources. Add PidsLimit in swarm Resources. Jun 14, 2017
@darkowlzz

Copy link
Copy Markdown
Contributor Author

This requires PidsLimit in swarmkit api. Creating another PR in docker/swarmkit for the same.

@cpuguy83 cpuguy83 added status/1-design-review status/failing-ci Indicates that the PR in its current state fails the test suite and removed status/0-triage labels Jun 14, 2017
@darkowlzz

Copy link
Copy Markdown
Contributor Author

This is not required for now as discussed in docker/cli#181. Closing...

@darkowlzz darkowlzz closed this Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/failing-ci Indicates that the PR in its current state fails the test suite status/1-design-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants