Visitar URL original
Add initial task extension conformance coverage by PranavSenthilnathan · Pull Request #1734 · modelcontextprotocol/csharp-sdk · GitHub
Skip to content

Add initial task extension conformance coverage - #1734

Merged
PranavSenthilnathan merged 5 commits into
modelcontextprotocol:mainfrom
PranavSenthilnathan:pranavsenthilnathan-prototype-task-conformance
Jul 25, 2026
Merged

Add initial task extension conformance coverage#1734
PranavSenthilnathan merged 5 commits into
modelcontextprotocol:mainfrom
PranavSenthilnathan:pranavsenthilnathan-prototype-task-conformance

Conversation

@PranavSenthilnathan

@PranavSenthilnathan PranavSenthilnathan commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Adds initial task-extension coverage from @modelcontextprotocol/conformance alpha.9 without introducing new public API.

  • Enables tasks-wire-fields, tasks-request-state-removal, and tasks-mrtr-input against the existing global WithTasks(store) behavior.
  • Adds the complete task conformance fixture; the seven remaining task scenarios are listed but commented out for incremental enablement.
  • Adds per-request Tasks capability metadata, capability gating for explicit task methods, task routing headers, and complete-result acknowledgements required by the enabled scenarios.
  • Adds focused serialization and client request metadata coverage.

The deferred scenarios mostly require per-tool synchronous/optional/required task configuration that the SDK does not currently expose. tasks-status-notifications separately awaits an upstream subscriptions/listen harness rewrite.

Validation

  • dotnet build
  • Full analyzer, ASP.NET Core, and core test suites across .NET 8, .NET 9, .NET 10, and .NET Framework 4.7.2
  • All three enabled task-extension scenarios pass on .NET 8, .NET 9, and .NET 10

Partially implements #1732.

PranavSenthilnathan and others added 2 commits July 24, 2026 14:51
@PranavSenthilnathan
Add task extension conformance coverage
2b4a7d2 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 7c99928c-a943-49f4-9a63-8b04a0e4d18b
@PranavSenthilnathan
Limit task conformance to existing API
2f19b70 
Remove the proposed per-tool execution mode API and enable only the task scenarios supported by the existing global task-store behavior. Keep deferred scenarios listed for future API work.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7c99928c-a943-49f4-9a63-8b04a0e4d18b
@PranavSenthilnathan
PranavSenthilnathan force-pushed the pranavsenthilnathan-prototype-task-conformance branch from 501854b to 2f19b70 Compare July 24, 2026 21:52
@PranavSenthilnathan PranavSenthilnathan changed the title Add task extension conformance coverage Add initial task extension conformance coverage Jul 24, 2026
@PranavSenthilnathan
PranavSenthilnathan marked this pull request as ready for review July 24, 2026 22:31
jeffhandley
jeffhandley previously approved these changes Jul 24, 2026
View reviewed changes

@jeffhandley jeffhandley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Cool seeing the gates implemented, how cleanly this plugs and passes. Cheers!

@PranavSenthilnathan
Generalize extension routing metadata
0a6ce37 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 7c99928c-a943-49f4-9a63-8b04a0e4d18b
jeffhandley
jeffhandley previously approved these changes Jul 24, 2026
View reviewed changes
Comment thread src/ModelContextProtocol.AspNetCore/StreamableHttpHandler.cs Resolved
Comment thread src/ModelContextProtocol.Core/Protocol/JsonRpcMessageContext.cs Resolved
@PranavSenthilnathan
Mark routing metadata APIs experimental
bfad171 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 7c99928c-a943-49f4-9a63-8b04a0e4d18b
jeffhandley
jeffhandley previously approved these changes Jul 24, 2026
View reviewed changes

@jeffhandley jeffhandley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will change the diagnostic in a separate PR

@PranavSenthilnathan
PranavSenthilnathan enabled auto-merge (squash) July 24, 2026 23:56
@PranavSenthilnathan
Exclude routing context from JSON
0dcd05b 
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 7c99928c-a943-49f4-9a63-8b04a0e4d18b
jeffhandley
jeffhandley reviewed Jul 25, 2026
View reviewed changes
Comment thread src/ModelContextProtocol.Core/Protocol/JsonRpcMessageContext.cs Resolved
jeffhandley
jeffhandley reviewed Jul 25, 2026
View reviewed changes
Comment thread tests/ModelContextProtocol.AspNetCore.Tests/ServerConformanceTests.cs Resolved
@PranavSenthilnathan
PranavSenthilnathan merged commit 83523b0 into modelcontextprotocol:main Jul 25, 2026
9 checks passed
@PranavSenthilnathan
PranavSenthilnathan deleted the pranavsenthilnathan-prototype-task-conformance branch July 25, 2026 00:16
@jeffhandley jeffhandley mentioned this pull request Jul 25, 2026
Merged
@PranavSenthilnathan PranavSenthilnathan mentioned this pull request Jul 28, 2026
Closed
@jeffhandley jeffhandley mentioned this pull request Jul 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffhandley jeffhandley jeffhandley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PranavSenthilnathan @jeffhandley