Visitar URL original
Add MessagePackMapper#handleBigIntegerAndBigDecimalAsString by komamitsu · Pull Request #768 · msgpack/msgpack-java · GitHub
Skip to content

Add MessagePackMapper#handleBigIntegerAndBigDecimalAsString #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komamitsu merged 2 commits into from
Oct 1, 2023
Merged

Add MessagePackMapper#handleBigIntegerAndBigDecimalAsString #768

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9ccdf9
Add MessagePackMapper#handleBigIntegerAndBigDecimalAsString
komamitsu Sep 30, 2023
eb65c7f
Rename unit test method names
komamitsu Sep 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename unit test method names
  • Loading branch information
@komamitsu
komamitsu committed Sep 30, 2023
commit eb65c7f8cdddaa3660e0450b45b9196f6c7a5ac8
20 changes: 10 additions & 10 deletions msgpack-jackson/src/test/java/org/msgpack/jackson/dataformat/MessagePackMapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ static class PojoWithBigDecimal
public BigDecimal value;
}

private void assertToFailToHandleBigInteger(MessagePackMapper messagePackMapper) throws JsonProcessingException
private void shouldFailToHandleBigInteger(MessagePackMapper messagePackMapper) throws JsonProcessingException
{
PojoWithBigInteger obj = new PojoWithBigInteger();
obj.value = BigInteger.valueOf(Long.MAX_VALUE).multiply(BigInteger.valueOf(10));
Expand All @@ -51,7 +51,7 @@ private void assertToFailToHandleBigInteger(MessagePackMapper messagePackMapper)
}
}

private void assertToSuccessToHandleBigInteger(MessagePackMapper messagePackMapper) throws IOException
private void shouldSuccessToHandleBigInteger(MessagePackMapper messagePackMapper) throws IOException
{
PojoWithBigInteger obj = new PojoWithBigInteger();
obj.value = BigInteger.valueOf(Long.MAX_VALUE).multiply(BigInteger.valueOf(10));
Expand All @@ -62,7 +62,7 @@ private void assertToSuccessToHandleBigInteger(MessagePackMapper messagePackMapp
assertEquals(obj.value, deserialized.value);
}

private void assertToFailToHandleBigDecimal(MessagePackMapper messagePackMapper) throws JsonProcessingException
private void shouldFailToHandleBigDecimal(MessagePackMapper messagePackMapper) throws JsonProcessingException
{
PojoWithBigDecimal obj = new PojoWithBigDecimal();
obj.value = new BigDecimal("1234567890.98765432100");
Expand All @@ -76,7 +76,7 @@ private void assertToFailToHandleBigDecimal(MessagePackMapper messagePackMapper)
}
}

private void assertToSuccessToHandleBigDecimal(MessagePackMapper messagePackMapper) throws IOException
private void shouldSuccessToHandleBigDecimal(MessagePackMapper messagePackMapper) throws IOException
{
PojoWithBigDecimal obj = new PojoWithBigDecimal();
obj.value = new BigDecimal("1234567890.98765432100");
Expand All @@ -90,22 +90,22 @@ private void assertToSuccessToHandleBigDecimal(MessagePackMapper messagePackMapp
@Test
public void handleBigIntegerAsString() throws IOException
{
assertToFailToHandleBigInteger(new MessagePackMapper());
assertToSuccessToHandleBigInteger(new MessagePackMapper().handleBigIntegerAsString());
shouldFailToHandleBigInteger(new MessagePackMapper());
shouldSuccessToHandleBigInteger(new MessagePackMapper().handleBigIntegerAsString());
}

@Test
public void handleBigDecimalAsString() throws IOException
{
assertToFailToHandleBigDecimal(new MessagePackMapper());
assertToSuccessToHandleBigDecimal(new MessagePackMapper().handleBigDecimalAsString());
shouldFailToHandleBigDecimal(new MessagePackMapper());
shouldSuccessToHandleBigDecimal(new MessagePackMapper().handleBigDecimalAsString());
}

@Test
public void handleBigIntegerAndBigDecimalAsString() throws IOException
{
MessagePackMapper messagePackMapper = new MessagePackMapper().handleBigIntegerAndBigDecimalAsString();
assertToSuccessToHandleBigInteger(messagePackMapper);
assertToSuccessToHandleBigDecimal(messagePackMapper);
shouldSuccessToHandleBigInteger(messagePackMapper);
shouldSuccessToHandleBigDecimal(messagePackMapper);
}
}