Visitar URL original
better error checks by methane · Pull Request #607 · msgpack/msgpack-python · GitHub
Skip to content

better error checks #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 2 commits into from
May 5, 2024
Merged

better error checks #607

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc3c748
better error checks
methane May 5, 2024
04ddc1b
fix test
methane May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test
  • Loading branch information
@methane
methane committed May 5, 2024
commit 04ddc1bdf69a005755f621efa18b1b0a29d1f5e0
4 changes: 3 additions & 1 deletion test/test_buffer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,14 @@ def test_packer_getbuffer():
packer.pack_array_header(2)
packer.pack(42)
packer.pack("hello")
assert bytes(packer) == b"\x92*\xa5hello"
buffer = packer.getbuffer()
assert isinstance(buffer, memoryview)
assert bytes(buffer) == b"\x92*\xa5hello"

if Packer.__module__ == "msgpack._cmsgpack": # only for Cython
# cython Packer supports buffer protocol directly
assert bytes(packer) == b"\x92*\xa5hello"

with raises(BufferError):
packer.pack(42)
buffer.release()
Expand Down