Visitar URL original
Harden `Unpacker.__init__` re-entry cleanup to prevent buffer/context leaks by Copilot · Pull Request #687 · msgpack/msgpack-python · GitHub
Skip to content

Harden Unpacker.__init__ re-entry cleanup to prevent buffer/context leaks #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 3 commits into from
Jun 3, 2026
Merged

Harden Unpacker.__init__ re-entry cleanup to prevent buffer/context leaks #687

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6afc0cc
Initial plan
Copilot Jun 3, 2026
ffc1b20
Fix Unpacker __init__ re-entry cleanup leaks
Copilot Jun 3, 2026
23da514
Apply suggestion from @methane
methane Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestion from @methane
  • Loading branch information
@methane
methane authored Jun 3, 2026
commit 23da5146a44848587eee11b8159b251b5ecf3951
4 changes: 0 additions & 4 deletions msgpack/_unpacker.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,6 @@ cdef class Unpacker:
cdef Py_ssize_t max_buffer_size
cdef uint64_t stream_offset

def __cinit__(self):
self.buf = NULL
unpack_init(&self.ctx)

def __dealloc__(self):
unpack_clear(&self.ctx)
PyMem_Free(self.buf)
Expand Down
Loading