Repository navigation
fix(octane): skip undefined prop writes and advertise visibility capability - #14
Open
aleclarson wants to merge 1 commit into
Open
aleclarson wants to merge 1 commit into
aleclarson wants to merge 1 commit into
Conversation
…bility setProp forwarded `undefined` to NativeScript native setters, which coerce it (e.g. `editable = undefined` becomes `ios.userInteractionEnabled = NO`), leaving dead UI that still has its JS listeners attached. `undefined` now means "prop not supplied" and the write is skipped. The driver already handles `visibility` commands (mapping hidden to NativeScript's `collapse`), so advertise the capability — this lets core retain committed suspense bodies while they are pending instead of discarding them. Also align the intrinsic ref types with Octane's ref contract: callback refs may return a cleanup function, and refs may be nested arrays with optional entries.
aleclarson
added a commit
to octane-xplat/octane-xplat
that referenced
this pull request
Oct 8, 2026
Filed upstream PRs for the five patch-audit fixes and recorded them via a new upstreamPR field on the manifest entries: - nativescript-community/octane#14 — setProp undefined-skip, visibility capability, intrinsic ref types - nativescript-community/octane#15 — vite-octane .tsrx HMR matching and recipients counting - nativescript-community/ui-image#69 — iOS prefetch cacheType + headers - nfrasser/linkifyjs#572 — ICU-free \p{} regex construction - facebook/lexical#9334 — @lexical/link URL_REGEX via new RegExp - NativeScript/NativeScript#11514 — font-weight → wght axis mapping on Android (issue #11513)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
setPropforwardsundefinedstraight to the NativeScript view setter. Native setters coerce it — e.g.editable = undefinedbecomesios.userInteractionEnabled = NO— leaving dead UI that still has its JS listeners attached.undefinedshould mean "prop not supplied".Separately, the driver already implements
visibilitycommands (mappinghiddento NativeScript'scollapse) but doesn't advertise the capability, so core never uses it — committed suspense bodies can't be retained while pending.Fix
setPropreturns early whenvalue === undefined(before the<name>Changeecho suppression).capabilitiesnow includesvisibility: true, matching thevisibilityop handler the driver already has.Reftype is aligned with Octane's ref contract: callback refs may return a cleanup function, and refs may be nested arrays with optional entries (the array variant moved intoRefitself, soOctaneAttributes.refstays a single entry).