Patch release 2.12.1 - #24168

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/go/plugin/go.d/collector/redfish/config_schema.json">

<violation number="1" location="src/go/plugin/go.d/collector/redfish/config_schema.json:94">
P2: The schema now accepts arbitrary unknown configuration keys, so misspelled settings no longer fail validation. Keep the root allowlist and explicitly permit the conditional credential fields and `name`.</violation>

<violation number="2" location="src/go/plugin/go.d/collector/redfish/config_schema.json:94">
P2: This reworked `dependencies` block makes the schema accept two config states that the runtime `validate()` (config.go) still rejects: a job with `auth_method` omitted (defaults to `auto`, which requires username+password) and a job with `auth_method: none` that also sets credentials. The test comment in `config_test.go` documents this as intentional for the form, which always submits `auth_method`; but the README-documented file path (`edit-config go.d/redfish.conf`) and API-submitted configs do not guarantee that, so those configs now pass schema validation and only fail when the job starts, whereas the pre-PR schema (the removed `allOf` else-branch) rejected them at save time. If edit-time parity with `validate()` is wanted for non-form paths, reintroduce the missing-method guard; otherwise this is a deliberate trade-off that is fine to keep.</violation>
</file>

<file name=".agents/skills/collectors-go-design/config-schema.md">

<violation number="1" location=".agents/skills/collectors-go-design/config-schema.md:141">
P2: This prohibition is broader than the JSON Schema failure it cites: `additionalProperties: false` remains valid when dependencies introduce no undeclared keys. Limit the rule and its test to dependency branches that add properties.</violation>
</file>

<file name="src/collectors/ebpf.plugin/libbpf_api/ebpf_library.c">

<violation number="1" location="src/collectors/ebpf.plugin/libbpf_api/ebpf_library.c:16">
P2: This bypasses the configured `btf path`, so hosts using a supplied BTF file without `/sys/kernel/btf/vmlinux` treat supported symbols as absent and disable the corresponding BTF-based paths. Query the already-loaded `default_btf` instead, and do not free that shared object.</violation>
</file>

<file name="src/collectors/ebpf.plugin/ebpf_sync.c">

<violation number="1" location="src/collectors/ebpf.plugin/ebpf_sync.c:368">
P3: `callocz()` already aborts the process on OOM in netdata, so `if (!sync_percpu_values) continue;` is unreachable dead code. Drop the guard (and the extra indentation it forces on the `stored` assignment). Note that if the check ever did fire, silently skipping the whole counters update for that iteration would be worse than the abort the allocator already performs.</violation>
</file>

<file name="src/collectors/ebpf.plugin/ebpf_disk.c">

<violation number="1" location="src/collectors/ebpf.plugin/ebpf_disk.c:92">
P2: The same completion program (`netdata_block_rq_complete`) is now attached to up to two completion events per request: the object's own `blk_mq_end_request` attach (`disk_bpf__attach` / `ebpf_attach_programs`) plus this new kprobe on `__blk_mq_end_request` (or `blk_mq_free_request`), and on kernels where `blk_mq_end_request()` calls `__blk_mq_end_request()` both fire for one completed request. The 'counted once' property (README) is therefore entirely program-side and cannot be verified from this repo since the kernel-collector object is out of tree. Confirm the inflight-map logic dedups (e.g., removes the per-request entry on first completion) so the histogram is not double-incremented for every blk-mq device; the fallback `blk_mq_free_request` also fires for aborted/errored/failed requests that never complete, so those paths must not be recorded as completions.</violation>
</file>

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/daemon/analytics.c">

<violation number="1" location="src/daemon/analytics.c:821">
P2: If `out_size` is too small for the best regional TZID, this skips that row and can return the lower-ranked `001` zone instead. Preserve the best-ranked match and return failure when it cannot fit; do not fall back to a different timezone.</violation>
</file>

<file name="src/go/plugin/go.d/docs/how-to-write-a-collector.md">

<violation number="1" location="src/go/plugin/go.d/docs/how-to-write-a-collector.md:355">
P3: The two other collectors cited as examples of this pattern do not match the description: `ap/doc.go` and `zfspool/doc.go` contain only the SPDX line and the package clause, with no doc comment, while the bullet prescribes "its doc comment" (and `smbios_memory/doc.go` is the one collector that has one). Align the wording with the examples (or note the doc comment is optional) so the recipe and its examples don't contradict each other.</violation>
</file>