Visitar URL original
fix(linux): share instance guard across login sessions by claucambra · Pull Request #11156 · nextcloud/desktop · GitHub
Skip to content

fix(linux): share instance guard across login sessions - #11156

Open
claucambra wants to merge 1 commit into
masterfrom
codex/fix-linux-single-instance-session-9729
Open

fix(linux): share instance guard across login sessions#11156
claucambra wants to merge 1 commit into
masterfrom
codex/fix-linux-single-instance-session-9729

Conversation

@claucambra

@claucambra claucambra commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

Resolves

Fixes #9729

Summary

Scope the Linux KDSingleApplication fallback to the configured executable name and user so desktop and systemd launches share an instance guard when XDG_SESSION_ID is missing or differs. Cover secondary detection, message forwarding, takeover after exit and separate application identities with subprocess tests.

Checklist

AI (if applicable)

@claucambra
fix(linux): share instance guard across login sessions
a779d1b 
Scope the Linux KDSingleApplication fallback to the configured executable name and user so desktop and systemd launches share an instance guard when XDG_SESSION_ID is missing or differs. Cover secondary detection, message forwarding, takeover after exit and separate application identities with subprocess tests.

Refs #9729

Assisted-by: Codex:GPT-6
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra added this to the 35.0.2 milestone Oct 29, 2026
@claucambra claucambra self-assigned this Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-11156.zip

Digest: sha256:89354509691f1c38c29f432afc5f6efebb0dd394b96f5c2ea149c4c3eeb062fa

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@github-actions

github-actions Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Artifact containing the Flatpak bundle: com.nextcloud.desktopclient.nextcloud.flatpak.zip

Digest: sha256:839e2363dafdcc833999f9a8648818f8e10a790a8374986300617d951dea4dee

To test this change/fix you can download the above artifact file, unzip it, and install the bundle with:
flatpak install --user com.nextcloud.desktopclient.nextcloud.flatpak

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud

sonarqubecloud Bot commented Oct 29, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nilsding nilsding modified the milestones: 35.0.2, 35.0.3 Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilasan camilasan Awaiting requested review from camilasan camilasan is a code owner
@i2h3 i2h3 Awaiting requested review from i2h3 i2h3 is a code owner
@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner
@nilsding nilsding Awaiting requested review from nilsding nilsding is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@claucambra claucambra

Labels

os: 🐧 Linux

Projects

None yet

Milestone

35.0.3

Development

Successfully merging this pull request may close these issues.

[Bug]: After upgrade from 4.x to 33.0, two instances of dekstop run at the same time and interfere with each other

2 participants

@claucambra @nilsding