Repository navigation
Make libgit2 an actual submodule - #1017
Merged
Merged
Conversation
Collaborator
Author
Collaborator
|
Cant rely on git being on the path, especially on windows :( |
Collaborator
Author
|
@maxkorp yeah we prompt in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should hopefully help us track how libgit2 changes from version to version by making it an actual submodule of the library.
I added scripts to automate updating any submodules of the repo so hopefully if we add more submodules (which I think I will) they should just be dropped in and work (famous last words).
Currently we do the following for updating submodules during a
lifecycleScripts/install:During a
generatewe just check to see if the submodules are all good (i.e. all initialized, on the correct commis and no work dir changes) and if any aren't we'll put up a warning in the console.