Visitar URL original
adds support for gpg commit signing (fixes #1018) by dabutvin · Pull Request #1448 · nodegit/nodegit · GitHub
Skip to content

adds support for gpg commit signing (fixes #1018) #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 3 commits into from
Jan 16, 2019
Merged

adds support for gpg commit signing (fixes #1018) #1448

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caee388
adds support for gpg commit signing (fixes #1018)
dabutvin Apr 14, 2018
6f6ff3b
remove callback from createCommitWithSignature
Dec 13, 2018
90e9d89
add final newline to commit buffer
dabutvin Dec 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add final newline to commit buffer 
 - the commit that gets created  and the signed content have to match
  • Loading branch information
@dabutvin
dabutvin committed Dec 16, 2018
commit 90e9d892bee058aa99e7e972ebb9a9b18dcbc5b5
2 changes: 1 addition & 1 deletion lib/repository.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,7 @@ Repository.prototype.createCommitWithSignature = function(
parents
);
}).then(function(commit_contentResult) {
commit_content = commit_contentResult;
commit_content = commit_contentResult + "\n";
return onSignature(commit_content);
}).then(function(signature) {
return Commit.createWithSignature(
Expand Down
2 changes: 1 addition & 1 deletion test/tests/commit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,7 +819,7 @@ describe("Commit", function() {
}

var test = this;
var expectedCommitId = "53bb69297148decb1d75e015f66a7e5f4e0476c9";
var expectedCommitId = "ccb99bb20716ef7c37e92c7b8db029a7af7f747b";
var fileName = "newfile.txt";
var fileContent = "hello world";

Expand Down