Visitar URL original
ESLint + Prettier + tsconfig by wmertens · Pull Request #1825 · nodegit/nodegit · GitHub
Skip to content

ESLint + Prettier + tsconfig #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wmertens wants to merge 6 commits into
base: master
Choose a base branch
from
Open

ESLint + Prettier + tsconfig #1825

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85e1e46
add eslint + prettier
wmertens Feb 27, 2021
dd16272
add tsconfig.json to allow TypeScript linting
wmertens Feb 27, 2021
b1749d3
jsdoc: fixes before lint fix
wmertens Jan 26, 2023
cfa5cd7
lint fixes
wmertens Mar 7, 2021
4f78356
lint++
wmertens Mar 7, 2021
90fc722
npm run lint
wmertens Feb 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint++
  • Loading branch information
@wmertens
wmertens committed Jan 26, 2023
commit 4f78356efdf8f0b7954db891130a05f620912f35
7 changes: 3 additions & 4 deletions generate/scripts/generateJson.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,15 +194,14 @@ module.exports = function generateJson() {
});
// Process enums
_(enums).forEach(function(enumerable) {
output.some(function(obj) {
for (const obj of output) {
if (enumerable.typeName.indexOf(obj.typeName) == 0) {
enumerable.owner = obj.jsClassName;
}
else if (enumerable.owner) {
return true;
break;
}
return false;
});
}

var override = descriptor.enums[enumerable.typeName] || {};

Expand Down
28 changes: 7 additions & 21 deletions generate/scripts/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,17 +110,11 @@ var Helpers = {
},

getLibgitType: function(normalizedType, types) {
var libgitType;

types.some(function (type) {
for (const type of types) {
if (type[0] === normalizedType) {
libgitType = type[1];
return true;
return type[1];
}
return false;
});

return libgitType;
}
},

processCallback: function(field) {
Expand All @@ -144,19 +138,12 @@ var Helpers = {
field.isOptional = true;
}
else {
var cbFieldName;

allFields.some(function (cbField) {
for (const cbField of allFields) {
if (Helpers.isPayloadFor(cbField, field.name)) {
cbFieldName = cbField.name;
return true;
field.payloadFor = cbField.name;
field.isOptional = true;
break;
}
return false;
});

if (cbFieldName) {
field.payloadFor = cbFieldName;
field.isOptional = true;
}
}
},
Expand Down Expand Up @@ -226,7 +213,6 @@ var Helpers = {
return fnDef;
});

typeDefOverrides = descriptor.types[typeDef.typeName] || {};
var functionOverrides = typeDefOverrides.functions || {};
typeDef.functions.forEach(function(fnDef) {
Helpers.decorateFunction(fnDef, typeDef, functionOverrides[fnDef.cFunctionName] || {}, enums);
Expand Down
8 changes: 4 additions & 4 deletions test/tests/revwalk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ describe("Revwalk", function() {
.then(function(commit) {
test.commit = commit;
})
.then(function() {
this.walker = this.repository.createRevWalk();
this.walker.sorting(NodeGit.Revwalk.SORT.TIME);
this.walker.push(this.commit.id());
.then(function () {
test.walker = test.repository.createRevWalk();
test.walker.sorting(NodeGit.Revwalk.SORT.TIME);
test.walker.push(test.commit.id());
});
});

Expand Down